Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 8733011: Add the CHECK_ISOLATE macro, which validates that the current isolate (Closed)

Created:
9 years ago by turnidge
Modified:
9 years ago
Reviewers:
Anton Muhin, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Anton Muhin
Visibility:
Public.

Description

Add some checking macros: CHECK_ISOLATE -- make sure that there is a current isolate. CHECK_NO_ISOLATE -- the opposite. CHECK_ISOLATE_SCOPE -- make sure that there is a current isolate and it has an API scope. DARTSCOPE changes to call CHECK_ISOLATE_SCOPE. If you don't want that, use DARTSCOPE_NOCHECKS. Went through all of the DART_EXPORT function and made sure they all had the appropriate checking. Rewrite DARTSCOPE a bit to avoid evaluating the macro param multiple times. Committed: https://code.google.com/p/dart/source/detail?r=1990

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -34 lines) Patch
M runtime/vm/dart_api_impl.h View 1 2 3 4 5 1 chunk +46 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 4 5 20 chunks +25 lines, -20 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 3 4 5 12 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
turnidge
9 years ago (2011-11-30 00:39:35 UTC) #1
siva
lgtm
9 years ago (2011-11-30 01:11:59 UTC) #2
turnidge
Made some changes. PTAL.
9 years ago (2011-11-30 19:23:54 UTC) #3
siva
lgtm
9 years ago (2011-12-01 00:17:15 UTC) #4
turnidge
(adding antonm to keep him in the loop)
9 years ago (2011-12-01 00:44:42 UTC) #5
Anton Muhin
9 years ago (2011-12-01 01:17:10 UTC) #6
Nice stuff.  If we break, we're ourselves to blame :)

Powered by Google App Engine
This is Rietveld 408576698