Fixing string compile-time constant evaluation

Fixing string compile-time constant evaluation

Committed: https://code.google.com/p/dart/source/detail?r=1905

[Siggi Cherem (dart-lang), 2011-11-29 18:46:30]

this fixes bugs mentioned by Bob and Peter. This should probably be simpler if
we normalized strings after we parse them.

[Jennifer Messerly, 2011-11-29 18:55:48]

http://codereview.chromium.org/8729018/diff/2001/frog/gen.dart
File frog/gen.dart (right):

http://codereview.chromium.org/8729018/diff/2001/frog/gen.dart#newcode1764
frog/gen.dart:1764: && xVal[0] != yVal[0]) {
does this need to handle multiline strings too?

http://codereview.chromium.org/8729018/diff/2001/frog/gen.dart#newcode1773
frog/gen.dart:1773: print("$xVal vs $yVal");
remove

http://codereview.chromium.org/8729018/diff/2001/frog/member.dart
File frog/member.dart (right):

http://codereview.chromium.org/8729018/diff/2001/frog/member.dart#newcode1188
frog/member.dart:1188: // ensure that both strings use the same quote char:
it'd be really nice if this was pulled out into its own function

[Siggi Cherem (dart-lang), 2011-11-29 19:09:26]

http://codereview.chromium.org/8729018/diff/2001/frog/gen.dart
File frog/gen.dart (right):

http://codereview.chromium.org/8729018/diff/2001/frog/gen.dart#newcode1764
frog/gen.dart:1764: && xVal[0] != yVal[0]) {
On 2011/11/29 18:55:48, John Messerly wrote:
> does this need to handle multiline strings too?

Thankfully no, we do normalize those.

http://codereview.chromium.org/8729018/diff/2001/frog/gen.dart#newcode1773
frog/gen.dart:1773: print("$xVal vs $yVal");
On 2011/11/29 18:55:48, John Messerly wrote:
> remove

oops. thanks.

http://codereview.chromium.org/8729018/diff/2001/frog/member.dart
File frog/member.dart (right):

http://codereview.chromium.org/8729018/diff/2001/frog/member.dart#newcode1188
frog/member.dart:1188: // ensure that both strings use the same quote char:
On 2011/11/29 18:55:48, John Messerly wrote:
> it'd be really nice if this was pulled out into its own function

Done.

[Jennifer Messerly, 2011-11-29 21:11:14]

lgtm