Issue 8728031: Fix handling of recompiling code for optimized and inlined functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8728031: Fix handling of recompiling code for optimized and inlined functions (Closed)

Created:
9 years ago by Søren Gjesse

Modified:
9 years ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix handling of recompiling code for optimized and inlined functions The debugger preparation did not take optimized functions - including inlined function into account. This caused the full-code used for deoptimization to be the "lazy compile" builtin which did not work and caused V8 to crash. R=yangguo@chromium.org BUG=chromium:105375, v8:1782 TEST=test/mjsunit/debug-break-inline.js Committed: http://code.google.com/p/v8/source/detail?r=10094

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed review comments #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -53 lines)			Patch
M	src/debug.cc	View		3 chunks	+20 lines, -5 lines	0 comments	Download
A +	test/mjsunit/debug-break-inline.js	View	1	1 chunk	+51 lines, -46 lines	0 comments	Download
M	test/mjsunit/debug-step-3.js	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

9 years ago (2011-11-30 08:56:52 UTC) #2

LGTM with nit.

http://codereview.chromium.org/8728031/diff/1/test/mjsunit/debug-break-inline.js
File test/mjsunit/debug-break-inline.js (right):

http://codereview.chromium.org/8728031/diff/1/test/mjsunit/debug-break-inline...
test/mjsunit/debug-break-inline.js:42: // Debug event listener which steps until
the global variable done is true.
I don't see a global variable named "done".  Outdated comment?

Expand Messages | Collapse Messages