Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 8726031: Change handling of accepting socket connections (Closed)

Created:
9 years ago by Søren Gjesse
Modified:
9 years ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Change handling of accepting socket connections The accept method have been removed from the ServerSocket class and the signature for the connectionHandler callback have been changed to provide the accepted socket as an argument. This is to avoid the possibility for accept to return null even in the case of pending connection. This could happen if an error like EAGAIN, EWOULDBLOCK and EINTR was returned by it OS accept call and previously there was no way of propagating this without returning null from the Dart call to accept. R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -55 lines) Patch
M runtime/bin/socket.dart View 1 chunk +4 lines, -9 lines 0 comments Download
M runtime/bin/socket_impl.dart View 1 chunk +13 lines, -2 lines 0 comments Download
M samples/chat/http_impl.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/src/EchoServerStreamTest.dart View 3 chunks +4 lines, -6 lines 0 comments Download
M tests/standalone/src/EchoServerTest.dart View 5 chunks +10 lines, -12 lines 0 comments Download
M tests/standalone/src/SocketCloseTest.dart View 3 chunks +16 lines, -18 lines 0 comments Download
M tests/standalone/src/SocketManyConnectionsTest.dart View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
9 years ago (2011-11-29 11:46:44 UTC) #1
Mads Ager (google)
9 years ago (2011-11-29 11:52:23 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698