Issue 8725009: More --use_slow_path tests, add that VMOption to two tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8725009: More --use_slow_path tests, add that VMOption to two tests. (Closed)

Created:
9 years ago by srdjan

Modified:
9 years ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More --use_slow_path tests, add that VMOption to two tests. Committed: https://code.google.com/p/dart/source/detail?r=1881

Patch Set 2 : '' #

Total comments: 4

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -7 lines)			Patch
M	runtime/vm/stub_code_ia32.cc	View	1	4 chunks	+20 lines, -7 lines	0 comments	Download
M	tests/language/src/ImplicitClosureTest.dart	View		1 chunk	+2 lines, -0 lines	2 comments	Download
M	tests/language/src/StaticImplicitClosureTest.dart	View		1 chunk	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM http://codereview.chromium.org/8725009/diff/3001/tests/language/src/ImplicitClosureTest.dart File tests/language/src/ImplicitClosureTest.dart (right): http://codereview.chromium.org/8725009/diff/3001/tests/language/src/ImplicitClosureTest.dart#newcode5 tests/language/src/ImplicitClosureTest.dart:5: // VMOptions= Is this line necessary? http://codereview.chromium.org/8725009/diff/3001/tests/language/src/StaticImplicitClosureTest.dart File ...

9 years ago (2011-11-28 23:25:47 UTC) #2

srdjan

9 years ago (2011-11-28 23:29:30 UTC) #3

http://codereview.chromium.org/8725009/diff/3001/tests/language/src/ImplicitC...
File tests/language/src/ImplicitClosureTest.dart (right):

http://codereview.chromium.org/8725009/diff/3001/tests/language/src/ImplicitC...
tests/language/src/ImplicitClosureTest.dart:5: // VMOptions=
On 2011/11/28 23:25:47, regis wrote:
> Is this line necessary?

Yes, so that we run it also with no VM options.

http://codereview.chromium.org/8725009/diff/3001/tests/language/src/StaticImp...
File tests/language/src/StaticImplicitClosureTest.dart (right):

http://codereview.chromium.org/8725009/diff/3001/tests/language/src/StaticImp...
tests/language/src/StaticImplicitClosureTest.dart:5: // VMOptions=
On 2011/11/28 23:25:47, regis wrote:
> Is this line necessary?

ditto

Expand Messages | Collapse Messages

Issue 8725009: More --use_slow_path tests, add that VMOption to two tests. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages