Issue 8725003: Integrate double-conversion into build-process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8725003: Integrate double-conversion into build-process. (Closed)

Created:
9 years ago by floitsch

Modified:
9 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Integrate double-conversion into build-process. Committed: https://code.google.com/p/dart/source/detail?r=1872

Patch Set 2 : rebase #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -2 lines)			Patch
M	runtime/dart-runtime.gyp	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/third_party/double-conversion/README.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	runtime/third_party/double-conversion/src/double-conversion.gypi	View	1 chunk	+47 lines, -0 lines	0 comments	Download
M	runtime/third_party/double-conversion/src/utils.h	View	5 chunks	+14 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip http://codereview.chromium.org/8725003/diff/1/runtime/third_party/double-conversion/src/utils.h File runtime/third_party/double-conversion/src/utils.h (right): http://codereview.chromium.org/8725003/diff/1/runtime/third_party/double-conversion/src/utils.h#newcode35 runtime/third_party/double-conversion/src/utils.h:35: #ifndef ASSERT Can you integrate all of ...

9 years ago (2011-11-28 18:45:07 UTC) #2

floitsch

9 years ago (2011-11-28 19:01:05 UTC) #3

http://codereview.chromium.org/8725003/diff/1/runtime/third_party/double-conv...
File runtime/third_party/double-conversion/src/utils.h (right):

http://codereview.chromium.org/8725003/diff/1/runtime/third_party/double-conv...
runtime/third_party/double-conversion/src/utils.h:35: #ifndef ASSERT
On 2011/11/28 18:45:07, Ivan Posva wrote:
> Can you integrate all of these local changes into the original sources?

I will put it onto my TODO list.

Expand Messages | Collapse Messages

Issue 8725003: Integrate double-conversion into build-process. (Closed)

Description

Patch Set 1 #

Patch Set 2 : rebase #

Messages