Issue 8724015: Properly detect name collisions at library level

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8724015: Properly detect name collisions at library level (Closed)

Created:
9 years ago by hausner

Modified:
9 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Properly detect name collisions at library level Fixing issue 592 Committed: https://code.google.com/p/dart/source/detail?r=1934

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -0 lines)			Patch
M	runtime/vm/parser.cc	View	3 chunks	+31 lines, -0 lines	0 comments	Download
A	tests/language/src/ToplevelCollision1Test.dart	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A	tests/language/src/ToplevelCollision2Test.dart	View	1 chunk	+20 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM with comment http://codereview.chromium.org/8724015/diff/1/tests/language/src/ToplevelCollision2Test.dart File tests/language/src/ToplevelCollision2Test.dart (right): http://codereview.chromium.org/8724015/diff/1/tests/language/src/ToplevelCollision2Test.dart#newcode9 tests/language/src/ToplevelCollision2Test.dart:9: set x(var i) { print(i); } ...

9 years ago (2011-11-30 00:37:35 UTC) #2

hausner

9 years ago (2011-11-30 18:52:48 UTC) #3

http://codereview.chromium.org/8724015/diff/1/tests/language/src/ToplevelColl...
File tests/language/src/ToplevelCollision2Test.dart (right):

http://codereview.chromium.org/8724015/diff/1/tests/language/src/ToplevelColl...
tests/language/src/ToplevelCollision2Test.dart:9: set x(var i) { print(i); }
On 2011/11/30 00:37:35, srdjan wrote:
> Add:
> /// 02: continued
> 
> so that there is a version that passes.

Doesn't work that way, apparently. Omitting as per our discussion.

Expand Messages | Collapse Messages