Introduce Dart_SetVMFlags API function.

Introduce Dart_SetVMFlags API function.

It should be possible to set command line arguments without providing isolate init callback.

Committed: https://code.google.com/p/dart/source/detail?r=1972

[siva, 2011-11-29 19:08:43]

Currently we have a certain amount of atomicity that flags initialization has
with Dart_initialize (i.e both happen together and only once).
By making it two calls that atomicity is lost. We need to ensure that atomicity
remains.

http://codereview.chromium.org/8713012/diff/5001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8713012/diff/5001/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:471: Flags::ProcessCommandLineFlags(argc, argv);
Currently we ensure that Dart_Initialize is called only once and hence
Flags::ProcessCommandLineFlags is also called only once.

In the new scheme it is possible to call Dart_SetVMFlags multiple times we
should protect against that and we should also ensure that Dart_SetVMFlags is
called before Dart_Initialize is called.

[podivilov, 2011-11-30 11:50:36]

PTAL.

http://codereview.chromium.org/8713012/diff/5001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8713012/diff/5001/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:471: Flags::ProcessCommandLineFlags(argc, argv);
On 2011/11/29 19:08:43, asiva wrote:
> Currently we ensure that Dart_Initialize is called only once and hence
> Flags::ProcessCommandLineFlags is also called only once.
> 
> In the new scheme it is possible to call Dart_SetVMFlags multiple times we
> should protect against that and we should also ensure that Dart_SetVMFlags is
> called before Dart_Initialize is called.

Done.

[siva, 2011-11-30 19:09:38]

lgtm once these comments are addressed.

http://codereview.chromium.org/8713012/diff/8001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

http://codereview.chromium.org/8713012/diff/8001/runtime/include/dart_api.h#n...
runtime/include/dart_api.h:265: DART_EXPORT void Dart_SetVMFlags(int argc, const
char** argv);
Please make this also return bool, so that we have true when it is set and false
when there is an error or multiple invokes.

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/dart.cc#newcode28
runtime/vm/dart.cc:28: if (vm_isolate_ != NULL) {
if (vm_isolate_ != NULL || !Flags::Initialized()) {
  return false;
}

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:525: DART_EXPORT void Dart_SetVMFlags(int argc,
const char** argv) {
void => bool

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:526: Flags::ProcessCommandLineFlags(argc, argv);
return Flags::ProcessCommandLineFlags(argc, argv);

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/flags.cc
File runtime/vm/flags.cc (right):

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/flags.cc#newcode230
runtime/vm/flags.cc:230: void Flags::ProcessCommandLineFlags(int
number_of_vm_flags,
void => bool

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/flags.cc#newcode234
runtime/vm/flags.cc:234: return;
return false; 
and remove the UNREACHABLE();

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/flags.cc#newcode276
runtime/vm/flags.cc:276: }
  return true;

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/flags.h
File runtime/vm/flags.h (right):

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/flags.h#newcode54
runtime/vm/flags.h:54: static void ProcessCommandLineFlags(int argc, const
char** argv);
change void to bool

[podivilov, 2011-12-01 11:10:22]

http://codereview.chromium.org/8713012/diff/8001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

http://codereview.chromium.org/8713012/diff/8001/runtime/include/dart_api.h#n...
runtime/include/dart_api.h:265: DART_EXPORT void Dart_SetVMFlags(int argc, const
char** argv);
On 2011/11/30 19:09:38, asiva wrote:
> Please make this also return bool, so that we have true when it is set and
false
> when there is an error or multiple invokes.

Done.

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/dart.cc#newcode28
runtime/vm/dart.cc:28: if (vm_isolate_ != NULL) {
On 2011/11/30 19:09:38, asiva wrote:
> if (vm_isolate_ != NULL || !Flags::Initialized()) {
>   return false;
> }

Done.

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:525: DART_EXPORT void Dart_SetVMFlags(int argc,
const char** argv) {
On 2011/11/30 19:09:38, asiva wrote:
> void => bool

Done.

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/dart_api_impl.cc#...
runtime/vm/dart_api_impl.cc:526: Flags::ProcessCommandLineFlags(argc, argv);
On 2011/11/30 19:09:38, asiva wrote:
> return Flags::ProcessCommandLineFlags(argc, argv);

Done.

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/flags.cc
File runtime/vm/flags.cc (right):

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/flags.cc#newcode230
runtime/vm/flags.cc:230: void Flags::ProcessCommandLineFlags(int
number_of_vm_flags,
On 2011/11/30 19:09:38, asiva wrote:
> void => bool

Done.

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/flags.cc#newcode234
runtime/vm/flags.cc:234: return;
On 2011/11/30 19:09:38, asiva wrote:
> return false; 
> and remove the UNREACHABLE();

Done.

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/flags.cc#newcode276
runtime/vm/flags.cc:276: }
On 2011/11/30 19:09:38, asiva wrote:
>   return true;

Done.

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/flags.h
File runtime/vm/flags.h (right):

http://codereview.chromium.org/8713012/diff/8001/runtime/vm/flags.h#newcode54
runtime/vm/flags.h:54: static void ProcessCommandLineFlags(int argc, const
char** argv);
On 2011/11/30 19:09:38, asiva wrote:
> change void to bool

Done.