Issue 8686016: Inline instance of test with List<Dynamic>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8686016: Inline instance of test with List<Dynamic>. (Closed)

Created:
9 years ago by srdjan

Modified:
9 years ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Inline instance of test with List<Dynamic>. Committed: https://code.google.com/p/dart/source/detail?r=1911

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -10 lines)			Patch
	M	runtime/vm/code_generator_ia32.cc	View	1	3 chunks	+21 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm http://codereview.chromium.org/8686016/diff/1/runtime/vm/code_generator_ia32.cc File runtime/vm/code_generator_ia32.cc (right): http://codereview.chromium.org/8686016/diff/1/runtime/vm/code_generator_ia32.cc#newcode1410 runtime/vm/code_generator_ia32.cc:1410: const TypeArguments& type_arguments = extra space?

9 years ago (2011-11-30 01:53:32 UTC) #2

srdjan

9 years ago (2011-11-30 01:58:16 UTC) #3

http://codereview.chromium.org/8686016/diff/1/runtime/vm/code_generator_ia32.cc
File runtime/vm/code_generator_ia32.cc (right):

http://codereview.chromium.org/8686016/diff/1/runtime/vm/code_generator_ia32....
runtime/vm/code_generator_ia32.cc:1410: const TypeArguments& type_arguments =
On 2011/11/30 01:53:32, asiva wrote:
> extra space?

Done.

Expand Messages | Collapse Messages

Issue 8686016: Inline instance of test with List<Dynamic>. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages