Issue 8678031: Optimize type checks of list and map literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8678031: Optimize type checks of list and map literals. (Closed)

Created:
9 years ago by regis

Modified:
9 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Optimize type checks of list and map literals. Introduce an ast node for explicit 'assignable to' type checks. Remove Instance::Is() helper. Committed: https://code.google.com/p/dart/source/detail?r=1827

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -53 lines)			Patch
M	runtime/lib/literal_factory.dart	View	1	2 chunks	+8 lines, -32 lines	0 comments	Download
M	runtime/vm/ast.h	View	1	2 chunks	+34 lines, -0 lines	0 comments	Download
M	runtime/vm/ast_printer.cc	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	7 chunks	+42 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages