Implement type checking of list literals (issue 220).

Implement type checking of list literals (issue 220).
Remove expose_core_impl flag.
Add tests.
Fix tests.
Cleanup type checking of map literals.
Committed: https://code.google.com/p/dart/source/detail?r=1809

[hausner, 2011-11-23 17:34:34]

LGTM with a couple of comments.

http://codereview.chromium.org/8676001/diff/1/runtime/lib/literal_factory.dart
File runtime/lib/literal_factory.dart (right):

http://codereview.chromium.org/8676001/diff/1/runtime/lib/literal_factory.dar...
runtime/lib/literal_factory.dart:16: // In checked mode only, rethrow an
eventual type error with a more user
eventual -> potential

http://codereview.chromium.org/8676001/diff/1/runtime/lib/literal_factory.dar...
runtime/lib/literal_factory.dart:18: try {
Instead of doing the type check here, could the parser add a type check AstNode
to the element expression node, so that the type is checked right after the
element is evaluated?

http://codereview.chromium.org/8676001/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/8676001/diff/1/runtime/vm/parser.cc#newcode6648
runtime/vm/parser.cc:6648: "list literal element must be a constant of type
'%s'",
Even though we indicate the column position of the element, it might be nice to
include the index value in the error message: "list literal element 5 must be
...."

[regis, 2011-11-23 19:29:43]

Thanks

http://codereview.chromium.org/8676001/diff/1/runtime/lib/literal_factory.dart
File runtime/lib/literal_factory.dart (right):

http://codereview.chromium.org/8676001/diff/1/runtime/lib/literal_factory.dar...
runtime/lib/literal_factory.dart:16: // In checked mode only, rethrow an
eventual type error with a more user
On 2011/11/23 17:34:34, hausner wrote:
> eventual -> potential

Done.

http://codereview.chromium.org/8676001/diff/1/runtime/lib/literal_factory.dar...
runtime/lib/literal_factory.dart:18: try {
On 2011/11/23 17:34:34, hausner wrote:
> Instead of doing the type check here, could the parser add a type check
AstNode
> to the element expression node, so that the type is checked right after the
> element is evaluated?

What would the advantage be? I would not be able to intercept the type error,
since it would happen in the caller of this factory.
I'll submit as is and revisit, since the script of the error may not be the
correct one and your suggestion may fix it.

http://codereview.chromium.org/8676001/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/8676001/diff/1/runtime/vm/parser.cc#newcode6648
runtime/vm/parser.cc:6648: "list literal element must be a constant of type
'%s'",
On 2011/11/23 17:34:34, hausner wrote:
> Even though we indicate the column position of the element, it might be nice
to
> include the index value in the error message: "list literal element 5 must be
> ...."

Done here and for map literals below.