Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 8674009: Test for finding correct method for overriden native method of hidden native class. (Closed)

Created:
9 years, 1 month ago by sra1
Modified:
9 years, 1 month ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Test for finding correct method for overriden native method of hidden native class. I think the current implementation of $patchMethod has bugs that make it 'mostly work'. It patches one step too high (either the object or the prototype of the subclass). That is why I needed to add test#2 to exhibit the behaviour I thought I would see on the first test. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1815

Patch Set 1 #

Patch Set 2 : add tests #

Patch Set 3 : Rename first test to be '1' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -0 lines) Patch
M tests/language/language.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A tests/language/src/NativeClassInheritance1FrogTest.dart View 1 2 1 chunk +101 lines, -0 lines 0 comments Download
A tests/language/src/NativeClassInheritance2FrogTest.dart View 1 1 chunk +78 lines, -0 lines 0 comments Download
A tests/language/src/NativeClassInheritance3FrogTest.dart View 1 1 chunk +98 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
9 years, 1 month ago (2011-11-23 05:35:55 UTC) #1
Jennifer Messerly
9 years, 1 month ago (2011-11-23 19:31:16 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698