Issue 8666012: Partial fix to client breakage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8666012: Partial fix to client breakage (Closed)

Created:
9 years, 1 month ago by hausner

Modified:
9 years, 1 month ago

Reviewers:
sra1, Jacob, Jennifer Messerly, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Partial fix to client breakage TBR Committed: https://code.google.com/p/dart/source/detail?r=1772

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -21 lines)			Patch
M	client/html/src/Element.dart	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	client/layout/SizingFunctions.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	client/observable/observable.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	client/samples/swarm/DataSource.dart	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	client/touch/Geometry.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	client/touch/Momentum.dart	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	client/touch/Scrollbar.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	client/touch/Scroller.dart	View	1 chunk	+9 lines, -5 lines	0 comments	Download
M	client/view/CompositeView.dart	View	1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sra1

http://codereview.chromium.org/8666012/diff/1/client/html/src/Element.dart File client/html/src/Element.dart (right): http://codereview.chromium.org/8666012/diff/1/client/html/src/Element.dart#newcode22 client/html/src/Element.dart:22: } Revert this - jacob fixed it.

9 years, 1 month ago (2011-11-23 01:16:44 UTC) #3

hausner

9 years, 1 month ago (2011-11-23 01:19:39 UTC) #4

Thanks.

There might be more to fix that I haven't run into yet.

Sorry, have to go pick up my kid...

Expand Messages | Collapse Messages