Issue 8662038: Refactor some of the duplicated code in the tests using a socket server

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8662038: Refactor some of the duplicated code in the tests using a socket server (Closed)

Created:
9 years, 1 month ago by Søren Gjesse

Modified:
9 years, 1 month ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Refactor some of the duplicated code in the tests using a socket server This is a first step in making these tests easier to understand. R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1838

Patch Set 1 #

Patch Set 2 : Added new file #

Patch Set 3 : Minor fix #

Total comments: 2

Patch Set 4 : Addressed review comments from ager@ #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -174 lines)			Patch
M	tests/standalone/src/EchoServerStreamTest.dart	View		4 chunks	+32 lines, -61 lines	0 comments	Download
M	tests/standalone/src/EchoServerTest.dart	View		5 chunks	+47 lines, -73 lines	0 comments	Download
M	tests/standalone/src/SocketManyConnectionsTest.dart	View		4 chunks	+17 lines, -40 lines	0 comments	Download
A	tests/standalone/src/TestingServer.dart	View	1 2 3	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm http://codereview.chromium.org/8662038/diff/4001/tests/standalone/src/TestingServer.dart File tests/standalone/src/TestingServer.dart (right): http://codereview.chromium.org/8662038/diff/4001/tests/standalone/src/TestingServer.dart#newcode1 tests/standalone/src/TestingServer.dart:1: class TestingServer extends Isolate { Please add copyright ...

9 years, 1 month ago (2011-11-24 12:01:42 UTC) #2

Søren Gjesse

9 years, 1 month ago (2011-11-24 12:11:16 UTC) #3

http://codereview.chromium.org/8662038/diff/4001/tests/standalone/src/Testing...
File tests/standalone/src/TestingServer.dart (right):

http://codereview.chromium.org/8662038/diff/4001/tests/standalone/src/Testing...
tests/standalone/src/TestingServer.dart:1: class TestingServer extends Isolate {
On 2011/11/24 12:01:42, Mads Ager wrote:
> Please add copyright header.

Done.

Expand Messages | Collapse Messages