Issue 8662019: Support for parsing returning qualified type. Issue 513.

Issue 8662019: Support for parsing returning qualified type. Issue 513. (Closed)

Created:
9 years, 1 month ago by scheglov

Modified:
9 years, 1 month ago

Reviewers:
codefu

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support for parsing returning qualified type. Issue 513. http://code.google.com/p/dart/issues/detail?id=513 R=codefu@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1805

Patch Set 2 : Tweak write spaces #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -14 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View		1 chunk	+16 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolutionContext.java	View		1 chunk	+9 lines, -10 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	1	3 chunks	+27 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

codefu

nits: white space. http://codereview.chromium.org/8662019/diff/1/compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java File compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java (right): http://codereview.chromium.org/8662019/diff/1/compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java#newcode62 compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java:62: white space http://codereview.chromium.org/8662019/diff/1/compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java#newcode73 compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java:73: white space ...

9 years, 1 month ago (2011-11-23 18:46:52 UTC) #2

codefu

On 2011/11/23 18:46:52, codefu wrote: > nits: white space. for clarification; lgtm after nits

9 years, 1 month ago (2011-11-23 18:52:06 UTC) #3

Expand Messages | Collapse Messages