Issue 8662004: Update test scripts to deal with current VM behavior on optional constructor arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8662004: Update test scripts to deal with current VM behavior on optional constructor arguments. (Closed)

Created:
9 years ago by Mads Ager (google)

Modified:
9 years ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update test scripts to deal with current VM behavior on optional constructor arguments. Find binaries in tests based on the platform we are running on. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1779

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review comments #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -30 lines)			Patch
M	runtime/bin/socket_stream.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/src/ProcessTestUtil.dart	View	1 chunk	+13 lines, -6 lines	0 comments	Download
M	tests/standalone/src/TestRunnerTest.dart	View	3 chunks	+12 lines, -21 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

9 years ago (2011-11-23 09:57:46 UTC) #2

lgtm

http://codereview.chromium.org/8662004/diff/1/tools/test.dart
File tools/test.dart (right):

http://codereview.chromium.org/8662004/diff/1/tools/test.dart#newcode30
tools/test.dart:30: print(pendingActivities);
Accidental edit.

Expand Messages | Collapse Messages