Issue 8659012: Add Dart API scoping around the call to Dart_HandleMessage.

Issue 8659012: Add Dart API scoping around the call to Dart_HandleMessage. (Closed)

Created:
9 years ago by turnidge

Modified:
9 years ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Søren Gjesse

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add Dart API scoping around the call to Dart_HandleMessage. This allows us to print the error message in the case that there is an uncaught exception while handling an inter-isolate message. Add a couple of unit tests that exercise Dart_RunLoop/Dart_HandleMessage a bit. Committed: https://code.google.com/p/dart/source/detail?r=1904

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -0 lines)			Patch
M	runtime/tests/vm/vm.status	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2 3 4	1 chunk	+74 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM. http://codereview.chromium.org/8659012/diff/6001/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): http://codereview.chromium.org/8659012/diff/6001/runtime/vm/dart_api_impl_test.cc#newcode2905 runtime/vm/dart_api_impl_test.cc:2905: EXPECT_VALID(result); Should we verify that result is indeed ...

9 years ago (2011-11-28 21:42:53 UTC) #2

turnidge

9 years ago (2011-11-29 20:46:58 UTC) #3

http://codereview.chromium.org/8659012/diff/6001/runtime/vm/dart_api_impl_tes...
File runtime/vm/dart_api_impl_test.cc (right):

http://codereview.chromium.org/8659012/diff/6001/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:2905: EXPECT_VALID(result);
On 2011/11/28 21:42:53, asiva wrote:
> Should we verify that result is indeed an unhandled exception?

It turns out that the main isolate doesn't have an unhandled exception.  That is
the *other* isolate.

http://codereview.chromium.org/8659012/diff/6001/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:2910: Isolate::SetInitCallback(saved);
On 2011/11/28 21:42:53, asiva wrote:
> The code in RunLoop_Sucess and RunLoop_Exception seems very identical except
for
> teh Dart_True, Dart_False arguments. Maybe it can factored out into a static
> method with an args parameter.

Done.

Expand Messages | Collapse Messages