Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8637013: Remove support for attribute event listeners. (Closed)

Created:
9 years, 1 month ago by podivilov
Modified:
9 years, 1 month ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove support for attribute event listeners. R=vsm@google.com BUG=5590885 Committed: https://code.google.com/p/dart/source/detail?r=1790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+987 lines, -8564 lines) Patch
M client/dom/benchmarks/dromaeo/Dromaeo.dart View 1 chunk +1 line, -3 lines 0 comments Download
M client/dom/benchmarks/dromaeo/tests/dom-attr.dart View 1 chunk +20 lines, -21 lines 0 comments Download
M client/dom/benchmarks/dromaeo/tests/dom-modify.dart View 1 chunk +46 lines, -47 lines 0 comments Download
M client/dom/benchmarks/dromaeo/tests/dom-query.dart View 1 chunk +90 lines, -91 lines 0 comments Download
M client/dom/benchmarks/dromaeo/tests/dom-traverse.dart View 1 chunk +62 lines, -63 lines 0 comments Download
M client/dom/generated/monkey_dom.js View 24 chunks +0 lines, -498 lines 0 comments Download
M client/dom/generated/src/frog/AbstractWorker.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/DOMApplicationCache.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M client/dom/generated/src/frog/DOMWindow.dart View 1 chunk +0 lines, -146 lines 0 comments Download
M client/dom/generated/src/frog/DedicatedWorkerContext.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Document.dart View 1 chunk +0 lines, -92 lines 0 comments Download
M client/dom/generated/src/frog/Element.dart View 1 chunk +0 lines, -88 lines 0 comments Download
M client/dom/generated/src/frog/EventSource.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/dom/generated/src/frog/FileReader.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M client/dom/generated/src/frog/FileWriter.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M client/dom/generated/src/frog/HTMLBodyElement.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M client/dom/generated/src/frog/HTMLFrameSetElement.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M client/dom/generated/src/frog/HTMLInputElement.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/IDBDatabase.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/dom/generated/src/frog/IDBRequest.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M client/dom/generated/src/frog/IDBTransaction.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/dom/generated/src/frog/IDBVersionChangeRequest.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/MessagePort.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Notification.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M client/dom/generated/src/frog/SharedWorkercontext.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/WebSocket.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M client/dom/generated/src/frog/Worker.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/WorkerContext.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/XMLHttpRequest.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M client/dom/generated/src/frog/XMLHttpRequestUpload.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M client/dom/generated/src/interface/AbstractWorker.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M client/dom/generated/src/interface/DOMApplicationCache.dart View 1 chunk +0 lines, -32 lines 0 comments Download
M client/dom/generated/src/interface/DOMWindow.dart View 1 chunk +0 lines, -292 lines 0 comments Download
M client/dom/generated/src/interface/DedicatedWorkerContext.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M client/dom/generated/src/interface/Document.dart View 1 chunk +0 lines, -184 lines 0 comments Download
M client/dom/generated/src/interface/Element.dart View 1 chunk +0 lines, -176 lines 0 comments Download
M client/dom/generated/src/interface/EventSource.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M client/dom/generated/src/interface/FileReader.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M client/dom/generated/src/interface/FileWriter.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M client/dom/generated/src/interface/HTMLBodyElement.dart View 1 chunk +0 lines, -56 lines 0 comments Download
M client/dom/generated/src/interface/HTMLFrameSetElement.dart View 1 chunk +0 lines, -56 lines 0 comments Download
M client/dom/generated/src/interface/HTMLInputElement.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M client/dom/generated/src/interface/IDBDatabase.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M client/dom/generated/src/interface/IDBRequest.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M client/dom/generated/src/interface/IDBTransaction.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M client/dom/generated/src/interface/IDBVersionChangeRequest.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M client/dom/generated/src/interface/MessagePort.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M client/dom/generated/src/interface/Notification.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M client/dom/generated/src/interface/SharedWorkercontext.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M client/dom/generated/src/interface/WebSocket.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M client/dom/generated/src/interface/Worker.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M client/dom/generated/src/interface/WorkerContext.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M client/dom/generated/src/interface/XMLHttpRequest.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M client/dom/generated/src/interface/XMLHttpRequestUpload.dart View 1 chunk +0 lines, -20 lines 0 comments Download
M client/dom/generated/src/wrapping/_AbstractWorkerWrappingImplementation.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMApplicationCacheWrappingImplementation.dart View 1 chunk +0 lines, -48 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMWindowWrappingImplementation.dart View 1 chunk +0 lines, -438 lines 0 comments Download
M client/dom/generated/src/wrapping/_DedicatedWorkerContextWrappingImplementation.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_DocumentWrappingImplementation.dart View 1 chunk +0 lines, -276 lines 0 comments Download
M client/dom/generated/src/wrapping/_ElementWrappingImplementation.dart View 1 chunk +0 lines, -264 lines 0 comments Download
M client/dom/generated/src/wrapping/_EventSourceWrappingImplementation.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M client/dom/generated/src/wrapping/_FileReaderWrappingImplementation.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M client/dom/generated/src/wrapping/_FileWriterWrappingImplementation.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLBodyElementWrappingImplementation.dart View 1 chunk +0 lines, -84 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLFrameSetElementWrappingImplementation.dart View 1 chunk +0 lines, -84 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLInputElementWrappingImplementation.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBDatabaseWrappingImplementation.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBRequestWrappingImplementation.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBTransactionWrappingImplementation.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBVersionChangeRequestWrappingImplementation.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_MessagePortWrappingImplementation.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_NotificationWrappingImplementation.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M client/dom/generated/src/wrapping/_SharedWorkercontextWrappingImplementation.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebSocketWrappingImplementation.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M client/dom/generated/src/wrapping/_WorkerContextWrappingImplementation.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_WorkerWrappingImplementation.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_XMLHttpRequestUploadWrappingImplementation.dart View 1 chunk +0 lines, -30 lines 0 comments Download
M client/dom/generated/src/wrapping/_XMLHttpRequestWrappingImplementation.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M client/dom/generated/wrapping_dom.js View 20 chunks +702 lines, -4686 lines 0 comments Download
M client/dom/generated/wrapping_dom_externs.js View 1 chunk +0 lines, -103 lines 0 comments Download
M client/dom/scripts/dartgenerator.py View 1 chunk +1 line, -0 lines 0 comments Download
M client/fling/dist/runtime/apps/adminz/adminz.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M client/samples/spirodraw/ColorPicker.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M client/samples/spirodraw/Spirodraw.dart View 2 chunks +12 lines, -12 lines 0 comments Download
M client/samples/sunflower/Sunflower.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M client/testing/unittest/unittest.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M client/tests/client/html/ElementTests.dart View 1 chunk +44 lines, -44 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
podivilov
9 years, 1 month ago (2011-11-22 14:44:36 UTC) #1
vsm
LGTM - thanks!
9 years, 1 month ago (2011-11-22 20:44:40 UTC) #2
vsm
9 years, 1 month ago (2011-11-22 20:47:16 UTC) #3 
On 2011/11/22 20:44:40, vsm wrote:
> LGTM - thanks!

Before you check this in, can you also run:
> cd client/dom
> ../tools/copy_dart.py frog frog_dom.dart 

This should create an additional change in:
client/dom/frog/frog_dom.dart

thanks!

Vijay

Powered by Google App Engine
This is Rietveld 408576698