Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 8636012: Make Dart test scripts work for the VM on Windows. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)
Modified:
9 years, 1 month ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make Dart test scripts work for the VM on Windows. Minor changes: - Set system to win32 for test expectation files. - Add the .exe executable postfix to binaries. - Do the magic to figure out if a test crashed. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M tools/testing/dart/test_options.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +16 lines, -2 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
9 years, 1 month ago (2011-11-22 14:58:05 UTC) #1
Bill Hesse
9 years, 1 month ago (2011-11-22 15:07:05 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698