Issue 8624001: Don't allow invoking a constructor as 'const' if it wasn't declared 'const'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8624001: Don't allow invoking a constructor as 'const' if it wasn't declared 'const'. (Closed)

Created:
9 years, 1 month ago by zundel

Modified:
9 years, 1 month ago

Reviewers:
scheglov, codefu

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't allow invoking a constructor as 'const' if it wasn't declared 'const'. BUG=5142545 Committed: https://code.google.com/p/dart/source/detail?r=1751

Patch Set 1 : Self-review #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -5 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java	View	4 chunks	+22 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantResolver.java	View	3 chunks	+45 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

This contains a few bits of code in CompileTimeConstResolver to resolve symbols in constructor initializers ...

9 years, 1 month ago (2011-11-21 22:21:17 UTC) #1

codefu

9 years, 1 month ago (2011-11-22 14:22:54 UTC) #2

On 2011/11/21 22:21:17, zundel wrote:
> This contains a few bits of code in CompileTimeConstResolver to resolve
symbols
> in constructor initializers that aren't actually checked in
> CompileTimeConstAnalyzer.  That code works, but there is a complication there
I
> haven't worked out yet, so I removed second pass on checking initializers from
> the Analyzer piece.

lgtm

Expand Messages | Collapse Messages