Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 8618011: Check for presence of native resolver in library for classes which have native fields only in reg... (Closed)

Created:
9 years, 1 month ago by siva
Modified:
9 years, 1 month ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Check for presence of native resolver in library for classes which have native fields only in regular run mode not while generating snapshots. While generating snapshots the native resolver is not set and would trigger this error. Committed: https://code.google.com/p/dart/source/detail?r=1728

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M vm/class_finalizer.h View 1 2 chunks +13 lines, -2 lines 0 comments Download
M vm/class_finalizer.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M vm/dart_api_impl.cc View 1 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
9 years, 1 month ago (2011-11-22 00:21:10 UTC) #1
Ivan Posva
LGTM -ip http://codereview.chromium.org/8618011/diff/1/vm/dart_api_impl.cc File vm/dart_api_impl.cc (right): http://codereview.chromium.org/8618011/diff/1/vm/dart_api_impl.cc#newcode445 vm/dart_api_impl.cc:445: bool generating_snapshot) { This is almost a ...
9 years, 1 month ago (2011-11-22 00:42:53 UTC) #2
siva
9 years, 1 month ago (2011-11-22 01:19:37 UTC) #3
http://codereview.chromium.org/8618011/diff/1/vm/dart_api_impl.cc
File vm/dart_api_impl.cc (right):

http://codereview.chromium.org/8618011/diff/1/vm/dart_api_impl.cc#newcode445
vm/dart_api_impl.cc:445: bool generating_snapshot) {
Made a default parameter.

On 2011/11/22 00:42:53, Ivan Posva wrote:
> This is almost a default parameter value.

Powered by Google App Engine
This is Rietveld 408576698