Issue 8618004: Fix Swarm to run again, and enable its test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8618004: Fix Swarm to run again, and enable its test (Closed)

Created:
9 years, 1 month ago by Jennifer Messerly

Modified:
9 years, 1 month ago

Reviewers:
jimhug, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, sra1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix Swarm to run again, and enable its test Something broke consts--they weren't being generated with the "var" prefix, so closures didn't work right. Not sure why we're only hitting this in Swarm tests. Also turn off type checks for DOM types until we put in the right fallback for is$ methods. TEST=swarm_test Committed: https://code.google.com/p/dart/source/detail?r=1722

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -117 lines)			Patch
M	client/tests/client/client.status	View	1 chunk	+1 line, -1 line	1 comment	Download
M	frog/frogsh	View	9 chunks	+113 lines, -113 lines	0 comments	Download
M	frog/gen.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/value.dart	View	1 chunk	+4 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm http://codereview.chromium.org/8618004/diff/1/client/tests/client/client.status File client/tests/client/client.status (right): http://codereview.chromium.org/8618004/diff/1/client/tests/client/client.status#newcode22 client/tests/client/client.status:22: samples/swarm/swarm_tests: Pass should we delete these 2 lines?

9 years, 1 month ago (2011-11-21 22:51:34 UTC) #2

jimhug

9 years, 1 month ago (2011-11-22 18:20:14 UTC) #3

lgtm

http://codereview.chromium.org/8618004/diff/1/frog/value.dart
File frog/value.dart (right):

http://codereview.chromium.org/8618004/diff/1/frog/value.dart#newcode343
frog/value.dart:343: // check methods, by catching it on Object.prototype like
VarMember does)
Niggling worry - does this change conflict with Stephen's recent commit to use
isHidden?

Expand Messages | Collapse Messages