Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 8609012: Fix timing of both dart and python test scripts. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)
Modified:
9 years, 1 month ago
Reviewers:
Søren Gjesse, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix timing of both dart and python test scripts. The scripts (in particular the python one) were not counting all of the setup code that is run before tests are started. The time reported by the progress indicator now matches the time reported by 'time test_script'. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1697

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -21 lines) Patch
M tools/test.dart View 1 chunk +7 lines, -1 line 1 comment Download
M tools/test.py View 8 chunks +15 lines, -10 lines 0 comments Download
M tools/testing/dart/test_progress.dart View 6 chunks +17 lines, -7 lines 1 comment Download
M tools/testing/dart/test_runner.dart View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (google)
9 years, 1 month ago (2011-11-21 10:03:57 UTC) #1
Søren Gjesse
lgtm
9 years, 1 month ago (2011-11-21 10:35:53 UTC) #2
kasperl
DBC: start_time -> startTime http://codereview.chromium.org/8609012/diff/1/tools/test.dart File tools/test.dart (right): http://codereview.chromium.org/8609012/diff/1/tools/test.dart#newcode38 tools/test.dart:38: var start_time = new Date.now(); ...
9 years, 1 month ago (2011-11-21 11:46:39 UTC) #3
Mads Ager (google)
9 years, 1 month ago (2011-11-21 11:47:24 UTC) #4
Thanks Kasper! I'll fix those. Using multiple languages in the same change
confused me. :-)

On 2011/11/21 11:46:39, kasperl wrote:
> DBC: start_time -> startTime
> 
> http://codereview.chromium.org/8609012/diff/1/tools/test.dart
> File tools/test.dart (right):
> 
> http://codereview.chromium.org/8609012/diff/1/tools/test.dart#newcode38
> tools/test.dart:38: var start_time = new Date.now();
> startTime
> 
>
http://codereview.chromium.org/8609012/diff/1/tools/testing/dart/test_progres...
> File tools/testing/dart/test_progress.dart (right):
> 
>
http://codereview.chromium.org/8609012/diff/1/tools/testing/dart/test_progres...
> tools/testing/dart/test_progress.dart:119: CompactProgressIndicator(Date
> start_time) : super(start_time);
> startTime

Powered by Google App Engine
This is Rietveld 408576698