Issue 8598021: Remove isOdd/isEven from num and double interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8598021: Remove isOdd/isEven from num and double interfaces. (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years, 1 month ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove isOdd/isEven from num and double interfaces. Committed: https://code.google.com/p/dart/source/detail?r=1760

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -11 lines)			Patch
M	corelib/src/num.dart	View	1 chunk	+0 lines, -2 lines	2 comments	Download
M	runtime/lib/double.dart	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cshapiro

lgtm http://codereview.chromium.org/8598021/diff/1/corelib/src/num.dart File corelib/src/num.dart (right): http://codereview.chromium.org/8598021/diff/1/corelib/src/num.dart#newcode27 corelib/src/num.dart:27: bool isNaN(); As an aside, these would seem ...

9 years, 1 month ago (2011-11-18 21:14:06 UTC) #2

srdjan

9 years, 1 month ago (2011-11-18 22:42:34 UTC) #3

http://codereview.chromium.org/8598021/diff/1/corelib/src/num.dart
File corelib/src/num.dart (right):

http://codereview.chromium.org/8598021/diff/1/corelib/src/num.dart#newcode27
corelib/src/num.dart:27: bool isNaN();
On 2011/11/18 21:14:06, cshapiro wrote:
> As an aside, these would seem to belong in the double interface and not here
in
> the parent interface.

As I understand it, this is a problem of num being used for double/int mixed
usage in dart->JS systems, and isNaN is needed. isNaN correctly returns false
for integers.

Expand Messages | Collapse Messages