Issue 8591025: Fix parsing of factory calls (issue 500).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8591025: Fix parsing of factory calls (issue 500). (Closed)

Created:
9 years, 1 month ago by regis

Modified:
9 years, 1 month ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix parsing of factory calls (issue 500). Add test. Fix test. Adjust co19 status file. Committed: https://code.google.com/p/dart/source/detail?r=1633

Patch Set 3 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -19 lines)			Patch
M	runtime/vm/parser.cc	View	1 2	6 chunks	+32 lines, -18 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
A	tests/language/src/Factory2Test.dart	View		1 chunk	+44 lines, -0 lines	0 comments	Download
M	tests/language/src/SavannahTest.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM with one question about disabled tests. http://codereview.chromium.org/8591025/diff/1/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): http://codereview.chromium.org/8591025/diff/1/tests/co19/co19-runtime.status#newcode253 tests/co19/co19-runtime.status:253: LangSpecTest/13_Types/13_4_Interface_Types/A07/t03: Fail ...

9 years, 1 month ago (2011-11-17 21:06:10 UTC) #2

regis

9 years, 1 month ago (2011-11-17 21:40:26 UTC) #3

Thanks

http://codereview.chromium.org/8591025/diff/1/tests/co19/co19-runtime.status
File tests/co19/co19-runtime.status (right):

http://codereview.chromium.org/8591025/diff/1/tests/co19/co19-runtime.status#...
tests/co19/co19-runtime.status:253:
LangSpecTest/13_Types/13_4_Interface_Types/A07/t03: Fail # Issue 441
On 2011/11/17 21:06:10, srdjan wrote:
> Why issue 441? (Type check error thrown too early)
> 
> I think you need to file a new co19 issue, saying that the values must
implement
> Hashable?

Good point. This one is different. Filed co19 issue 53.

Expand Messages | Collapse Messages

Issue 8591025: Fix parsing of factory calls (issue 500). (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages