Issue 8589017: Dart test scripts: fix progress time indication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8589017: Dart test scripts: fix progress time indication. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Dart test scripts: fix progress time indication. Also, fix recursive configuration expansion (--mode=debug,release) and allow test selection patterns in arbitrary position on the command line and not just at the end (./tools/test.dart co19 -m release). R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1606

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -6 lines)			Patch
	M	tools/testing/dart/test_options.dart	View		2 chunks	+10 lines, -5 lines	1 comment	Download
	M	tools/testing/dart/test_progress.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

9 years, 1 month ago (2011-11-17 09:17:53 UTC) #2

LGTM.

http://codereview.chromium.org/8589017/diff/1/tools/testing/dart/test_options...
File tools/testing/dart/test_options.dart (right):

http://codereview.chromium.org/8589017/diff/1/tools/testing/dart/test_options...
tools/testing/dart/test_options.dart:156: continue;
Nice.  I was thinking that it is annoying not to allow options to be tacked on
at the end of the command line.

Expand Messages | Collapse Messages