Addresses a ClassCastException seen in the editor from MemberBuilder

Addresses a ClassCastException seen in the editor from MemberBuilder

Added a simple test to protect against the class cast exception and a JUnit test to
exercise it.

BUG=413
Committed: https://code.google.com/p/dart/source/detail?r=1663

[codefu, 2011-11-17 21:10:50]

http://codereview.chromium.org/8588038/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
(right):

http://codereview.chromium.org/8588038/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java:304:
"class Object {}",
ws?

http://codereview.chromium.org/8588038/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java:311:
public void testBadConstFactory() {
Generative Constructor vs Factory

http://codereview.chromium.org/8588038/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java:335: " 
A.foo(arg) : this.val = arg;",
Needs const.

[zundel, 2011-11-18 00:29:51]

After a discussion with John, I added a distinct message for the situation where
too many qualifiers were used.  The other message was not helpful.

http://codereview.chromium.org/8588038/diff/1/compiler/javatests/com/google/d...
File compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
(right):

http://codereview.chromium.org/8588038/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java:304:
"class Object {}",
On 2011/11/17 21:10:50, codefu wrote:
> ws?

Done.

http://codereview.chromium.org/8588038/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java:311:
public void testBadConstFactory() {
On 2011/11/17 21:10:50, codefu wrote:
> Generative Constructor vs Factory

Done.

http://codereview.chromium.org/8588038/diff/1/compiler/javatests/com/google/d...
compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java:335: " 
A.foo(arg) : this.val = arg;",
On 2011/11/17 21:10:50, codefu wrote:
> Needs const.

I was really trying to test a generative constructor, not a const constructor.

[zundel, 2011-11-18 13:05:45]

http://codereview.chromium.org/8588038/diff/4001/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java (right):

http://codereview.chromium.org/8588038/diff/4001/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java:183: //
Nothing else is valid. Already warned in getMethodKind().
Mabye a library element should be valid in the case where a factory constructor
is being created. I'll check into this.

[zundel, 2011-11-18 15:27:03]

I created a unit test case and Peter looked it over and said it seemed
reasonable.  Even after removing the 'internal error' there is no crash and
still fails with intelligible errors, and the 'internal error' gets in the way
of reporting some other problems.

[mmendez, 2011-11-18 16:32:23]

LGTM

On 2011/11/18 15:27:03, zundel wrote:
> I created a unit test case and Peter looked it over and said it seemed
> reasonable.  Even after removing the 'internal error' there is no crash and
> still fails with intelligible errors, and the 'internal error' gets in the way
> of reporting some other problems.