Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 8588027: - Allocate instantiated type arguments in new gen. (Closed)

Created:
9 years, 1 month ago by Ivan Posva
Modified:
9 years, 1 month ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org, ahe
Visibility:
Public.

Description

- Allocate instantiated type arguments in new gen. Committed: https://code.google.com/p/dart/source/detail?r=1605

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M vm/object.cc View 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
9 years, 1 month ago (2011-11-17 08:41:01 UTC) #1
Ivan Posva
TBR=regis
9 years, 1 month ago (2011-11-17 08:41:23 UTC) #2
regis
LGTM, but more can be done. http://codereview.chromium.org/8588027/diff/1/vm/object.cc File vm/object.cc (right): http://codereview.chromium.org/8588027/diff/1/vm/object.cc#newcode2062 vm/object.cc:2062: ParameterizedType::New(cls, type_arguments)); This ...
9 years, 1 month ago (2011-11-17 16:46:23 UTC) #3
Ivan Posva
9 years, 1 month ago (2011-11-17 16:57:19 UTC) #4
Regis,

Thanks for looking at other objects involved in runtime types. As you said we
should discuss the expected life-time of all type-related objects.

-Ivan

Powered by Google App Engine
This is Rietveld 408576698