Addition to CodePatcher

Will be used by the debugger to find static calls in Dart code.
Committed: https://code.google.com/p/dart/source/detail?r=1621

[srdjan, 2011-11-17 01:32:55]

DBC

http://codereview.chromium.org/8588014/diff/1/runtime/vm/code_patcher_arm.cc
File runtime/vm/code_patcher_arm.cc (right):

http://codereview.chromium.org/8588014/diff/1/runtime/vm/code_patcher_arm.cc#...
runtime/vm/code_patcher_arm.cc:25: UNIMPLEMENTED();
Add return false.

http://codereview.chromium.org/8588014/diff/1/runtime/vm/code_patcher_ia32.cc
File runtime/vm/code_patcher_ia32.cc (right):

http://codereview.chromium.org/8588014/diff/1/runtime/vm/code_patcher_ia32.cc...
runtime/vm/code_patcher_ia32.cc:29: ASSERT(*reinterpret_cast<uint8_t*>(start_ +
2 * kInstructionSize) == 0xE8);
Merge the 3 asserts into one using IsValidCallPattern

http://codereview.chromium.org/8588014/diff/1/runtime/vm/code_patcher_ia32.cc...
runtime/vm/code_patcher_ia32.cc:33: static bool IsValidCallPattern(uword
return_address) {
Could be called DartCallPattern::IsValid instead of
DartCallPattern::IsValidCallPattern.

http://codereview.chromium.org/8588014/diff/1/runtime/vm/code_patcher_x64.cc
File runtime/vm/code_patcher_x64.cc (right):

http://codereview.chromium.org/8588014/diff/1/runtime/vm/code_patcher_x64.cc#...
runtime/vm/code_patcher_x64.cc:25: UNIMPLEMENTED();
ditto

[hausner, 2011-11-17 16:33:02]

http://codereview.chromium.org/8588014/diff/1/runtime/vm/code_patcher_arm.cc
File runtime/vm/code_patcher_arm.cc (right):

http://codereview.chromium.org/8588014/diff/1/runtime/vm/code_patcher_arm.cc#...
runtime/vm/code_patcher_arm.cc:25: UNIMPLEMENTED();
On 2011/11/17 01:32:55, srdjan wrote:
> Add return false.

Done.

http://codereview.chromium.org/8588014/diff/1/runtime/vm/code_patcher_ia32.cc
File runtime/vm/code_patcher_ia32.cc (right):

http://codereview.chromium.org/8588014/diff/1/runtime/vm/code_patcher_ia32.cc...
runtime/vm/code_patcher_ia32.cc:29: ASSERT(*reinterpret_cast<uint8_t*>(start_ +
2 * kInstructionSize) == 0xE8);
On 2011/11/17 01:32:55, srdjan wrote:
> Merge the 3 asserts into one using IsValidCallPattern

Done.

http://codereview.chromium.org/8588014/diff/1/runtime/vm/code_patcher_ia32.cc...
runtime/vm/code_patcher_ia32.cc:33: static bool IsValidCallPattern(uword
return_address) {
On 2011/11/17 01:32:55, srdjan wrote:
> Could be called DartCallPattern::IsValid instead of
> DartCallPattern::IsValidCallPattern.

Done.

http://codereview.chromium.org/8588014/diff/1/runtime/vm/code_patcher_x64.cc
File runtime/vm/code_patcher_x64.cc (right):

http://codereview.chromium.org/8588014/diff/1/runtime/vm/code_patcher_x64.cc#...
runtime/vm/code_patcher_x64.cc:25: UNIMPLEMENTED();
On 2011/11/17 01:32:55, srdjan wrote:
> ditto

Done.

[siva, 2011-11-17 18:44:22]

lgtm

http://codereview.chromium.org/8588014/diff/5001/runtime/vm/code_patcher_arm.cc
File runtime/vm/code_patcher_arm.cc (right):

http://codereview.chromium.org/8588014/diff/5001/runtime/vm/code_patcher_arm....
runtime/vm/code_patcher_arm.cc:26: return true;
return false;
would be better here I feel.

http://codereview.chromium.org/8588014/diff/5001/runtime/vm/code_patcher_x64.cc
File runtime/vm/code_patcher_x64.cc (right):

http://codereview.chromium.org/8588014/diff/5001/runtime/vm/code_patcher_x64....
runtime/vm/code_patcher_x64.cc:26: return true;
Ditto.

[hausner, 2011-11-17 18:51:25]

http://codereview.chromium.org/8588014/diff/5001/runtime/vm/code_patcher_arm.cc
File runtime/vm/code_patcher_arm.cc (right):

http://codereview.chromium.org/8588014/diff/5001/runtime/vm/code_patcher_arm....
runtime/vm/code_patcher_arm.cc:26: return true;
On 2011/11/17 18:44:22, asiva wrote:
> return false;
> would be better here I feel.

true.

http://codereview.chromium.org/8588014/diff/5001/runtime/vm/code_patcher_x64.cc
File runtime/vm/code_patcher_x64.cc (right):

http://codereview.chromium.org/8588014/diff/5001/runtime/vm/code_patcher_x64....
runtime/vm/code_patcher_x64.cc:26: return true;
On 2011/11/17 18:44:22, asiva wrote:
> Ditto.

Done.