Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8588010: Regenerate from IDL with LANGUAGE_JAVASCRIPT on (Closed)

Created:
9 years, 1 month ago by vsm
Modified:
9 years, 1 month ago
Reviewers:
sra, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Regenerate from IDL with LANGUAGE_JAVASCRIPT on Committed: https://code.google.com/p/dart/source/detail?r=1620

Patch Set 1 #

Total comments: 4

Patch Set 2 : Map Array to List #

Unified diffs Side-by-side diffs Delta from patch set Stats (+904 lines, -232 lines) Patch
M client/dom/generated/monkey_dom.js View 1 39 chunks +56 lines, -15 lines 0 comments Download
M client/dom/generated/monkey_dom_externs.js View 1 15 chunks +17 lines, -5 lines 0 comments Download
M client/dom/generated/src/frog/CanvasRenderingContext2D.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/Clipboard.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/DOMException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/DOMSelection.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/DOMTokenList.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/DOMWindow.dart View 1 5 chunks +8 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/DedicatedWorkerContext.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Document.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Event.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/EventException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/FileException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/HTMLAnchorElement.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/HTMLAppletElement.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/HTMLDocument.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/HTMLEmbedElement.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/HTMLInputElement.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/HTMLLinkElement.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/HTMLSelectElement.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/frog/IDBDatabaseException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/JavaScriptCallFrame.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/KeyboardEvent.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Location.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/MessageEvent.dart View 1 1 chunk +6 lines, -4 lines 0 comments Download
M client/dom/generated/src/frog/MessagePort.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/MouseEvent.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/OperationNotAllowedException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/RGBColor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/Range.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M client/dom/generated/src/frog/RangeException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/ScriptProfileNode.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/WheelEvent.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/frog/Worker.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M client/dom/generated/src/frog/WorkerContext.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/XMLHttpRequestException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/frog/XPathException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/CanvasRenderingContext2D.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/Clipboard.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/DOMException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/DOMSelection.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/DOMTokenList.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/DOMWindow.dart View 1 5 chunks +10 lines, -2 lines 0 comments Download
M client/dom/generated/src/interface/DedicatedWorkerContext.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/interface/Document.dart View 4 chunks +8 lines, -2 lines 0 comments Download
M client/dom/generated/src/interface/Event.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/EventException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/FileException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/HTMLAnchorElement.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/HTMLAppletElement.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/interface/HTMLDocument.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/HTMLEmbedElement.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/interface/HTMLInputElement.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/dom/generated/src/interface/HTMLLinkElement.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/HTMLOptionElement.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/HTMLSelectElement.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/dom/generated/src/interface/IDBDatabaseException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/JavaScriptCallFrame.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/KeyboardEvent.dart View 2 chunks +0 lines, -10 lines 0 comments Download
M client/dom/generated/src/interface/Location.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/MessageEvent.dart View 1 1 chunk +6 lines, -4 lines 0 comments Download
M client/dom/generated/src/interface/MessagePort.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/interface/MouseEvent.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/OperationNotAllowedException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/RGBColor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M client/dom/generated/src/interface/Range.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M client/dom/generated/src/interface/RangeException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/ScriptProfileNode.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/Worker.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M client/dom/generated/src/interface/WorkerContext.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/XMLHttpRequestException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/interface/XPathException.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_CanvasRenderingContext2DWrappingImplementation.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_ClipboardWrappingImplementation.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMExceptionWrappingImplementation.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMSelectionWrappingImplementation.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMTokenListWrappingImplementation.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMWindowWrappingImplementation.dart View 1 5 chunks +44 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_DedicatedWorkerContextWrappingImplementation.dart View 1 1 chunk +19 lines, -7 lines 0 comments Download
M client/dom/generated/src/wrapping/_DocumentWrappingImplementation.dart View 4 chunks +14 lines, -5 lines 0 comments Download
M client/dom/generated/src/wrapping/_EventExceptionWrappingImplementation.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_EventWrappingImplementation.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_FileExceptionWrappingImplementation.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLAnchorElementWrappingImplementation.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLAppletElementWrappingImplementation.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLDocumentWrappingImplementation.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLEmbedElementWrappingImplementation.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLInputElementWrappingImplementation.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLLinkElementWrappingImplementation.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLOptionElementWrappingImplementation.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLSelectElementWrappingImplementation.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBDatabaseExceptionWrappingImplementation.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_JavaScriptCallFrameWrappingImplementation.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_KeyboardEventWrappingImplementation.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M client/dom/generated/src/wrapping/_LocationWrappingImplementation.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_MessageEventWrappingImplementation.dart View 1 1 chunk +14 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_MessagePortWrappingImplementation.dart View 1 2 chunks +18 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_MouseEventWrappingImplementation.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_OperationNotAllowedExceptionWrappingImplementation.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_RGBColorWrappingImplementation.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M client/dom/generated/src/wrapping/_RangeExceptionWrappingImplementation.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_RangeWrappingImplementation.dart View 2 chunks +10 lines, -3 lines 0 comments Download
M client/dom/generated/src/wrapping/_ScriptProfileNodeWrappingImplementation.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_WorkerContextWrappingImplementation.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_WorkerWrappingImplementation.dart View 1 2 chunks +16 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_XMLHttpRequestExceptionWrappingImplementation.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/src/wrapping/_XPathExceptionWrappingImplementation.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M client/dom/generated/wrapping_dom.js View 1 47 chunks +376 lines, -57 lines 0 comments Download
M client/dom/generated/wrapping_dom_externs.js View 1 22 chunks +24 lines, -16 lines 0 comments Download
M client/dom/scripts/dartgenerator.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M client/dom/scripts/fremontcutbuilder.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vsm
Here's the final bit for IDL regen. Note, this undoes my hand hack on initWebKitWheelEvent. ...
9 years, 1 month ago (2011-11-16 23:45:44 UTC) #1
sra1
http://codereview.chromium.org/8588010/diff/1/client/dom/generated/src/frog/Worker.dart File client/dom/generated/src/frog/Worker.dart (right): http://codereview.chromium.org/8588010/diff/1/client/dom/generated/src/frog/Worker.dart#newcode6 client/dom/generated/src/frog/Worker.dart:6: void postMessage(String message) native; The old IDL had an ...
9 years, 1 month ago (2011-11-17 00:18:12 UTC) #2
vsm
http://codereview.chromium.org/8588010/diff/1/client/dom/generated/src/frog/Worker.dart File client/dom/generated/src/frog/Worker.dart (right): http://codereview.chromium.org/8588010/diff/1/client/dom/generated/src/frog/Worker.dart#newcode6 client/dom/generated/src/frog/Worker.dart:6: void postMessage(String message) native; I added general fix to ...
9 years, 1 month ago (2011-11-17 00:37:09 UTC) #3
sra1
9 years, 1 month ago (2011-11-17 00:49:10 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698