Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 8586052: Better error handling when scanning library tags (Closed)

Created:
9 years, 1 month ago by hausner
Modified:
9 years, 1 month ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Better error handling when scanning library tags Fixes Issue 516 http://code.google.com/p/dart/issues/detail?id=516 #!/dart_bin ##library("foo"); void main() { print("goodbye"); } Errors encountered while loading script: '/private/tmp/t.dart': Error: line 2 pos 2: Unrecognized library tag ##library("foo"); ^ Committed: https://code.google.com/p/dart/source/detail?r=1664

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M runtime/vm/scanner.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/scanner.cc View 2 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hausner
9 years, 1 month ago (2011-11-18 17:20:13 UTC) #1
Ivan Posva
9 years, 1 month ago (2011-11-18 17:50:08 UTC) #2
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698