Issue 8586040: Added a factory test that fails in frog and dartc. Will add bug numbers to status file once the c...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8586040: Added a factory test that fails in frog and dartc. Will add bug numbers to status file once the c... (Closed)

Created:
9 years, 1 month ago by srdjan

Modified:
9 years ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Added a factory test that fails in frog and dartc. Will add bug numbers to status file once the correctness of the test has been confirmed. Committed: https://code.google.com/p/dart/source/detail?r=1666

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -0 lines)			Patch
	M	tests/language/language.status	View	1 2 3 4	2 chunks	+4 lines, -0 lines	0 comments	Download
	A	tests/language/src/FactoryImplementationTest.dart	View	1 2 3	1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! http://codereview.chromium.org/8586040/diff/1/tests/language/src/FactoryImplementationTest.dart File tests/language/src/FactoryImplementationTest.dart (right): http://codereview.chromium.org/8586040/diff/1/tests/language/src/FactoryImplementationTest.dart#newcode25 tests/language/src/FactoryImplementationTest.dart:25: // This factory will never be invoked. Please ...

9 years, 1 month ago (2011-11-18 11:31:13 UTC) #2

srdjan

9 years ago (2011-12-21 22:30:44 UTC) #3

http://codereview.chromium.org/8586040/diff/1/tests/language/src/FactoryImple...
File tests/language/src/FactoryImplementationTest.dart (right):

http://codereview.chromium.org/8586040/diff/1/tests/language/src/FactoryImple...
tests/language/src/FactoryImplementationTest.dart:25: // This factory will never
be invoked.
On 2011/11/18 11:31:13, ahe wrote:
> Please add:
> 
> // TODO(ahe): Is this a compile-time error?

Done.

Expand Messages | Collapse Messages