Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 8585044: Fixes issues in string interpolation tests (Closed)

Created:
9 years, 1 month ago by Jennifer Messerly
Modified:
9 years, 1 month ago
Reviewers:
jimhug
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixes issues in string interpolation tests This started as my attempt to add a test for http://codereview.chromium.org/8591010/, but it snowballed into fixing other issues when I discovered that StringInterpolateTest was failing already. Committed: https://code.google.com/p/dart/source/detail?r=1634

Patch Set 1 #

Patch Set 2 : merged #

Patch Set 3 : remove debugging code #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+915 lines, -849 lines) Patch
M frog/frogsh View 1 2 320 chunks +848 lines, -818 lines 1 comment Download
M frog/gen.dart View 2 chunks +13 lines, -1 line 0 comments Download
M frog/scripts/token_info.py View 1 chunk +1 line, -1 line 0 comments Download
M frog/scripts/tokenizer_gen.py View 2 chunks +8 lines, -2 lines 0 comments Download
M frog/tokenizer.dart View 1 chunk +19 lines, -8 lines 0 comments Download
M frog/tokenizer.g.dart View 3 chunks +6 lines, -2 lines 2 comments Download
M frog/value.dart View 1 2 3 chunks +14 lines, -8 lines 1 comment Download
M tests/co19/co19-frog.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language.status View 1 3 chunks +1 line, -4 lines 0 comments Download
M tests/language/src/StringInterpolateTest.dart View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jennifer Messerly
tbr I know we had some questions about what $a$b$c *should* do in string interpolation, ...
9 years, 1 month ago (2011-11-17 21:48:29 UTC) #1
jimhug
9 years, 1 month ago (2011-11-18 17:05:29 UTC) #2
LGTM!

Any time a fix snowballs into fixing more bugs it's fine with me.  I'm a little
sad that you disrupted my non-violent protest of the $ confusions - but I guess
that following the spec is more important than my feelings <smile>.

http://codereview.chromium.org/8585044/diff/4001/frog/frogsh
File frog/frogsh (right):

http://codereview.chromium.org/8585044/diff/4001/frog/frogsh#newcode14577
frog/frogsh:14577: function lang_Token(kind, source, start, end) {
TODO: There seems to be some sort of non-determinism in which of the
Token/Node/Parser/etc. types gets the prefix.  We should try to get this
deterministic in order to better take advantage of these diffs.

http://codereview.chromium.org/8585044/diff/4001/frog/tokenizer.g.dart
File frog/tokenizer.g.dart (right):

http://codereview.chromium.org/8585044/diff/4001/frog/tokenizer.g.dart#newcod...
frog/tokenizer.g.dart:376: static bool isIdentifierStart(int c) {
This definition is now incorrect - if you want to follow the spec. I believe
that '$' is a legal identifier start character.  In the tokenizer, you handle
this in the '$' case so I don't think there's a real but in the code, but this
method name should be changed or its behavior should be changed to be correct.

http://codereview.chromium.org/8585044/diff/4001/frog/tokenizer.g.dart#newcod...
frog/tokenizer.g.dart:396: static bool isInterpIdentifierPart(int c) {
FYI - I really hate this -but I can't fault you for just following the spec...

http://codereview.chromium.org/8585044/diff/4001/frog/value.dart
File frog/value.dart (right):

http://codereview.chromium.org/8585044/diff/4001/frog/value.dart#newcode137
frog/value.dart:137: var m = type.resolveMember('noSuchMethod');
Funny, I have this same change sitting in my current CL <smile>.

Powered by Google App Engine
This is Rietveld 408576698