Issue 8585028: Split PrivateMemberTest multi-test into separate tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8585028: Split PrivateMemberTest multi-test into separate tests. (Closed)

Created:
9 years, 1 month ago by karlklose

Modified:
8 years, 8 months ago

Reviewers:
Bill Hesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Split PrivateMemberTest multi-test into separate tests. BUG=http://code.google.com/p/dart/issues/detail?id=353 Committed: https://code.google.com/p/dart/source/detail?r=1978

Patch Set 1 #

Patch Set 2 : Rebase and delete one file. #

Patch Set 3 : Add failing frog test. #

Patch Set 4 : Remove one test. #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -74 lines)			Patch
M	tests/language/language.status	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
A +	tests/language/src/PrivateMember1LibB.dart	View		1 chunk	+2 lines, -11 lines	0 comments	Download
A	tests/language/src/PrivateMember1NegativeTest.dart	View		1 chunk	+19 lines, -0 lines	1 comment	Download
A +	tests/language/src/PrivateMember2LibB.dart	View		1 chunk	+2 lines, -11 lines	0 comments	Download
A	tests/language/src/PrivateMember2NegativeTest.dart	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A +	tests/language/src/PrivateMember3LibB.dart	View		1 chunk	+2 lines, -11 lines	0 comments	Download
A	tests/language/src/PrivateMember3NegativeTest.dart	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	tests/language/src/PrivateMemberLibA.dart	View	1	1 chunk	+0 lines, -23 lines	0 comments	Download
M	tests/language/src/PrivateMemberLibB.dart	View	1	1 chunk	+4 lines, -10 lines	0 comments	Download
M	tests/language/src/PrivateMemberTest.dart	View	1	1 chunk	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 8 months ago (2012-04-13 13:45:17 UTC) #4

http://codereview.chromium.org/8585028/diff/3014/tests/language/src/PrivateMe...
File tests/language/src/PrivateMember1NegativeTest.dart (right):

http://codereview.chromium.org/8585028/diff/3014/tests/language/src/PrivateMe...
tests/language/src/PrivateMember1NegativeTest.dart:7:
#import('PrivateMemberLibB1.dart');
This file does not exist.

Expand Messages | Collapse Messages