Issue 8578003: Implement setPosition on File to seek to a byte position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8578003: Implement setPosition on File to seek to a byte position. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement setPosition on File to seek to a byte position. R=sgjesse@google.com BUG=dart:263 TEST=standalone/FileTest Committed: https://code.google.com/p/dart/source/detail?r=1573

Patch Set 2 : Address review comments. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -3 lines)			Patch
M	runtime/bin/builtin_in.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/file.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/file.cc	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	runtime/bin/file.dart	View		2 chunks	+14 lines, -2 lines	0 comments	Download
M	runtime/bin/file_impl.dart	View	1	5 chunks	+45 lines, -0 lines	0 comments	Download
M	runtime/bin/file_linux.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/bin/file_macos.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/bin/file_win.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/standalone/src/FileTest.dart	View		2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm http://codereview.chromium.org/8578003/diff/1/runtime/bin/file_impl.dart File runtime/bin/file_impl.dart (right): http://codereview.chromium.org/8578003/diff/1/runtime/bin/file_impl.dart#newcode777 runtime/bin/file_impl.dart:777: var handler = (_setPositionHandler != null) ? _setPositionHandler ...

9 years, 1 month ago (2011-11-16 15:24:11 UTC) #2

Mads Ager (google)

9 years, 1 month ago (2011-11-16 15:49:17 UTC) #3

http://codereview.chromium.org/8578003/diff/1/runtime/bin/file_impl.dart
File runtime/bin/file_impl.dart (right):

http://codereview.chromium.org/8578003/diff/1/runtime/bin/file_impl.dart#newc...
runtime/bin/file_impl.dart:777: var handler = (_setPositionHandler != null) ?
_setPositionHandler : () => null;
On 2011/11/16 15:24:11, Søren Gjesse wrote:
> Long line.

Done.

Expand Messages | Collapse Messages

Issue 8578003: Implement setPosition on File to seek to a byte position. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comments. #

Messages