Issue 8574052: Start extracting common test_config.dart functionality into a utility library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8574052: Start extracting common test_config.dart functionality into a utility library. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Start extracting common test_config.dart functionality into a utility library. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1607

Patch Set 2 : Address review comments. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -215 lines)			Patch
M	tests/co19/test_config.dart	View		2 chunks	+9 lines, -79 lines	0 comments	Download
M	tests/corelib/test_config.dart	View		2 chunks	+11 lines, -67 lines	0 comments	Download
M	tests/standalone/test_config.dart	View		2 chunks	+11 lines, -69 lines	0 comments	Download
A	tools/testing/dart/test_config_utils.dart	View	1	1 chunk	+96 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. http://codereview.chromium.org/8574052/diff/1/tools/testing/dart/test_config_utils.dart File tools/testing/dart/test_config_utils.dart (right): http://codereview.chromium.org/8574052/diff/1/tools/testing/dart/test_config_utils.dart#newcode33 tools/testing/dart/test_config_utils.dart:33: for (var vmOptions in vmOptionsList) { I like ...

9 years, 1 month ago (2011-11-17 09:35:24 UTC) #2

Mads Ager (google)

9 years, 1 month ago (2011-11-17 09:38:06 UTC) #3

http://codereview.chromium.org/8574052/diff/1/tools/testing/dart/test_config_...
File tools/testing/dart/test_config_utils.dart (right):

http://codereview.chromium.org/8574052/diff/1/tools/testing/dart/test_config_...
tools/testing/dart/test_config_utils.dart:33: for (var vmOptions in
vmOptionsList) {
On 2011/11/17 09:35:24, Bill Hesse wrote:
> I like better 
> if (vmOptionsList.isEmpty() {
>   result.add(args);
> } else {
>   for loop
> }
> return result;

Done. I actually like the early return better but will not insist on it. :-)

Expand Messages | Collapse Messages

Issue 8574052: Start extracting common test_config.dart functionality into a utility library. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address review comments. #

Messages