Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 8567016: Fix a spurious warning in Frog selfhost (Closed)

Created:
9 years, 1 month ago by Jennifer Messerly
Modified:
9 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix a spurious warning in Frog selfhost. Pretty simple bug, VarMember was not passing through isDynamic (a perhaps misnamed flag whose main effect is to suppress warnings when we're building a dynamic call). Also don't suppress actual assertion generation when "isDynamic" is set. Committed: https://code.google.com/p/dart/source/detail?r=1526

Patch Set 1 #

Patch Set 2 : updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -74 lines) Patch
M frog/corejs.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M frog/frogsh View 1 90 chunks +141 lines, -68 lines 0 comments Download
M frog/member.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download
M frog/value.dart View 1 3 chunks +8 lines, -2 lines 0 comments Download
M frog/var_member.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-frog.status View 1 1 chunk +0 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698