Issue 8566008: Sort the file members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8566008: Sort the file members. (Closed)

Created:
9 years, 1 month ago by mmendez

Modified:
9 years, 1 month ago

Reviewers:
codefu

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Sort the file members and return long instead of doubles for size items. Committed: https://code.google.com/p/dart/source/detail?r=1512

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+129 lines, -129 lines)			Patch
	M	compiler/java/com/google/dart/compiler/metrics/CompilerMetrics.java	View		4 chunks	+129 lines, -129 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mmendez

9 years, 1 month ago (2011-11-14 16:39:08 UTC) #2

On 2011/11/14 16:36:12, codefu wrote:
> LGTM.  Should we just do this as a file by file basis?

I think so.  Unfortunately, I forgot to undo a couple of method signature
changes here before sending this out.  I'd suggest that moving forward, when we
go to edit a file that is not sorted, we sort it, commit and then do the real
edits

Expand Messages | Collapse Messages