Issue 8566001: Implement test selection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8566001: Implement test selection. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement test selection. Make it very simple and flexible. I don't think we need to make it more restrictive than this. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1502

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -1 line)			Patch
M	tests/corelib/test_config.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	tests/standalone/test_config.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View	1	3 chunks	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM, but there is a type error. http://codereview.chromium.org/8566001/diff/1/tools/testing/dart/test_options.dart File tools/testing/dart/test_options.dart (right): http://codereview.chromium.org/8566001/diff/1/tools/testing/dart/test_options.dart#newcode210 tools/testing/dart/test_options.dart:210: patterns[i] = ...

9 years, 1 month ago (2011-11-14 11:22:10 UTC) #2

Mads Ager (google)

9 years, 1 month ago (2011-11-14 11:25:37 UTC) #3

http://codereview.chromium.org/8566001/diff/1/tools/testing/dart/test_options...
File tools/testing/dart/test_options.dart (right):

http://codereview.chromium.org/8566001/diff/1/tools/testing/dart/test_options...
tools/testing/dart/test_options.dart:210: patterns[i] = new RegExp(patterns[i]);
On 2011/11/14 11:22:10, Bill Hesse wrote:
> patterns has type List<String>.

Yes, thanks!

Expand Messages | Collapse Messages