tools/test.dart: Enable // DartOptions= lines in Dart test runner.

tools/test.dart: Enable // DartOptions= lines in Dart test runner.


BUG=
TEST=tools/test.dart

Committed: https://code.google.com/p/dart/source/detail?r=1503

[Bill Hesse, 2011-11-14 11:58:11]

http://codereview.chromium.org/8565006/diff/1/tests/corelib/test_config.dart
File tests/corelib/test_config.dart (right):

http://codereview.chromium.org/8565006/diff/1/tests/corelib/test_config.dart#...
tests/corelib/test_config.dart:109: throw new Exception('More than one "//
DartOptions=" line in test');
add "... in test $filename".

Perhaps this should not throw, but just print the error, and continue?

[Mads Ager (google), 2011-11-14 12:03:55]

lgtm

http://codereview.chromium.org/8565006/diff/1/tests/corelib/test_config.dart
File tests/corelib/test_config.dart (right):

http://codereview.chromium.org/8565006/diff/1/tests/corelib/test_config.dart#...
tests/corelib/test_config.dart:109: throw new Exception('More than one "//
DartOptions=" line in test');
On 2011/11/14 11:58:12, Bill Hesse wrote:
> add "... in test $filename".
> 
> Perhaps this should not throw, but just print the error, and continue?

I think throwing is fine. The test will not behave as the author expects and we
should make that clear. Either the test should fail with this error message or
we should throw.