Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 8562010: Disable dartc tests failing on Mac OS X. (Closed)

Created:
9 years, 1 month ago by srdjan
Modified:
9 years ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Disable dartc tests failing on Mac OS X. Committed: https://code.google.com/p/dart/source/detail?r=1769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M tests/co19/co19-compiler.status View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
9 years, 1 month ago (2011-11-21 20:35:06 UTC) #1
Ivan Posva
LGTM -ip
9 years, 1 month ago (2011-11-23 00:30:35 UTC) #2
zundel
9 years ago (2011-11-28 18:24:07 UTC) #3
On 2011/11/23 00:30:35, Ivan Posva wrote:
> LGTM -ip

FYI, I just updated dartc to use less memory in the case of two of the tests
causing crashes, but I don't have a Mac to confirm whether or not this fixes the
problem.

http://codereview.chromium.org//8698021

Powered by Google App Engine
This is Rietveld 408576698