Issue 8549021: Attempt to fix buildbot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8549021: Attempt to fix buildbot. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Bill Hesse, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Attempt to fix buildbot. Having multiple tests write and delete the same file is not such a great idea. :-) R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1655

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -10 lines)			Patch
	M	tests/standalone/src/FileTest.dart	View		11 chunks	+17 lines, -10 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

9 years, 1 month ago (2011-11-18 14:11:49 UTC) #3

http://codereview.chromium.org/8549021/diff/1/tests/standalone/src/FileTest.dart
File tests/standalone/src/FileTest.dart (right):

http://codereview.chromium.org/8549021/diff/1/tests/standalone/src/FileTest.d...
tests/standalone/src/FileTest.dart:428: File file = new File(filename +
"_out_close_exception_stream");
String interpolation for the win?

Expand Messages | Collapse Messages