Issue 8549009: Refactor the library tag handler to share code between standalone dart and the snapshot generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8549009: Refactor the library tag handler to share code between standalone dart and the snapshot generator. (Closed)

Created:
9 years, 1 month ago by siva

Modified:
9 years, 1 month ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

Refactor the library tag handler to share code between standalone dart and the snapshot generator. Committed: https://code.google.com/p/dart/source/detail?r=1665

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+278 lines, -322 lines)			Patch
M	bin/bin.gypi	View	1 2 3 4	5 chunks	+0 lines, -10 lines	0 comments	Download
M	bin/dartutils.h	View	1 2 3 4	2 chunks	+60 lines, -0 lines	0 comments	Download
M	bin/dartutils.cc	View	1 2 3 4	3 chunks	+156 lines, -0 lines	0 comments	Download
M	bin/gen_snapshot.cc	View	1 2 3 4	5 chunks	+15 lines, -89 lines	0 comments	Download
M	bin/main.cc	View	1 2 3 4	2 chunks	+47 lines, -1 line	0 comments	Download
M	bin/process_script.h	View	1 2 3 4	1 chunk	+0 lines, -63 lines	0 comments	Download
D	bin/process_script.cc	View	1 2 3 4	1 chunk	+0 lines, -159 lines	0 comments	Download

Total messages: 3 (0 generated)

Anton Muhin

LGTM. One suggestion: process_script.cc is now RIP. Maybe move the stuff out of process_script.h as ...

9 years, 1 month ago (2011-11-18 14:30:28 UTC) #2

Done (removed process_script.h)