Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Issue 8548010: Wrapper dom changes in preparation for SVG (Closed)

Created:
9 years, 1 month ago by sra1
Modified:
9 years, 1 month ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Wrapper dom changes in preparation for SVG SVG defines methods that override base class methods. This requires the Dart static helper methods to have unique names since Dart inconveniently does not permit static method shadowing. Rather than furr up all the names with yet another copy of the class or interface name, this change only adds the interface name if there actually is a base class method of the same name. Almost all of this change is due to applying the same technique to the attribute getters and setters, which makes many names a little shorter. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1646

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : tweak #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7163 lines, -7115 lines) Patch
M client/dom/generated/src/wrapping/_AbstractWorkerWrappingImplementation.dart View 1 2 1 chunk +14 lines, -14 lines 0 comments Download
M client/dom/generated/src/wrapping/_ArrayBufferViewWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_ArrayBufferWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_AttrWrappingImplementation.dart View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M client/dom/generated/src/wrapping/_BarInfoWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_BeforeLoadEventWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_BlobWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_CSSCharsetRuleWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_CSSFontFaceRuleWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_CSSImportRuleWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_CSSMediaRuleWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_CSSPageRuleWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_CSSPrimitiveValueWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_CSSRuleListWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_CSSRuleWrappingImplementation.dart View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M client/dom/generated/src/wrapping/_CSSStyleDeclarationWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_CSSStyleRuleWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_CSSStyleSheetWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_CSSValueListWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_CSSValueWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_CanvasPixelArrayWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_CanvasRenderingContext2DWrappingImplementation.dart View 1 2 1 chunk +68 lines, -68 lines 0 comments Download
M client/dom/generated/src/wrapping/_CanvasRenderingContextWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_CharacterDataWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_ClientRectListWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_ClientRectWrappingImplementation.dart View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M client/dom/generated/src/wrapping/_ClipboardWrappingImplementation.dart View 1 2 1 chunk +14 lines, -14 lines 0 comments Download
M client/dom/generated/src/wrapping/_CloseEventWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_CompositionEventWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_ConsoleWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_CoordinatesWrappingImplementation.dart View 1 2 1 chunk +14 lines, -14 lines 0 comments Download
M client/dom/generated/src/wrapping/_CounterWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_CustomEventWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMApplicationCacheWrappingImplementation.dart View 1 2 1 chunk +44 lines, -44 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMExceptionWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMFileSystemSyncWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMFileSystemWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMMimeTypeArrayWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMMimeTypeWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMPluginArrayWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMPluginWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMSelectionWrappingImplementation.dart View 1 2 1 chunk +22 lines, -22 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMSettableTokenListWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMTokenListWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_DOMWindowWrappingImplementation.dart View 1 2 3 chunks +472 lines, -472 lines 0 comments Download
M client/dom/generated/src/wrapping/_DataTransferItemListWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_DataTransferItemWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_DatabaseSyncWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_DatabaseWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_DedicatedWorkerContextWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_DeviceMotionEventWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_DeviceOrientationEventWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_DocumentTypeWrappingImplementation.dart View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M client/dom/generated/src/wrapping/_DocumentWrappingImplementation.dart View 1 2 1 chunk +270 lines, -270 lines 0 comments Download
M client/dom/generated/src/wrapping/_ElementTraversalWrappingImplementation.dart View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M client/dom/generated/src/wrapping/_ElementWrappingImplementation.dart View 1 2 1 chunk +220 lines, -220 lines 0 comments Download
M client/dom/generated/src/wrapping/_EntityWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_EntryArraySyncWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_EntryArrayWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_EntrySyncWrappingImplementation.dart View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M client/dom/generated/src/wrapping/_EntryWrappingImplementation.dart View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M client/dom/generated/src/wrapping/_ErrorEventWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_EventExceptionWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_EventSourceWrappingImplementation.dart View 1 2 2 chunks +26 lines, -26 lines 0 comments Download
M client/dom/generated/src/wrapping/_EventWrappingImplementation.dart View 1 2 1 chunk +28 lines, -28 lines 0 comments Download
M client/dom/generated/src/wrapping/_FileErrorWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_FileExceptionWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_FileListWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_FileReaderWrappingImplementation.dart View 1 2 1 chunk +30 lines, -30 lines 0 comments Download
M client/dom/generated/src/wrapping/_FileWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_FileWriterSyncWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_FileWriterWrappingImplementation.dart View 1 2 1 chunk +32 lines, -32 lines 0 comments Download
M client/dom/generated/src/wrapping/_Float32ArrayWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_Float64ArrayWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_GeopositionWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLAllCollectionWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLAnchorElementWrappingImplementation.dart View 1 2 1 chunk +84 lines, -84 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLAppletElementWrappingImplementation.dart View 1 2 1 chunk +44 lines, -44 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLAreaElementWrappingImplementation.dart View 1 2 1 chunk +46 lines, -46 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLBRElementWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLBaseElementWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLBaseFontElementWrappingImplementation.dart View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLBodyElementWrappingImplementation.dart View 1 2 1 chunk +80 lines, -80 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLButtonElementWrappingImplementation.dart View 1 2 1 chunk +52 lines, -52 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLCanvasElementWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLCollectionWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLDListElementWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLDataListElementWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLDetailsElementWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLDirectoryElementWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLDivElementWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLDocumentWrappingImplementation.dart View 1 2 1 chunk +46 lines, -46 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLElementWrappingImplementation.dart View 1 2 1 chunk +84 lines, -84 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLEmbedElementWrappingImplementation.dart View 1 2 1 chunk +24 lines, -24 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLFieldSetElementWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLFontElementWrappingImplementation.dart View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLFormElementWrappingImplementation.dart View 1 2 1 chunk +40 lines, -40 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLFrameElementWrappingImplementation.dart View 1 2 1 chunk +44 lines, -44 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLFrameSetElementWrappingImplementation.dart View 1 2 1 chunk +64 lines, -64 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLHRElementWrappingImplementation.dart View 1 2 1 chunk +16 lines, -16 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLHeadElementWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLHeadingElementWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLHtmlElementWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLIFrameElementWrappingImplementation.dart View 1 2 1 chunk +48 lines, -48 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLImageElementWrappingImplementation.dart View 1 2 1 chunk +66 lines, -66 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLInputElementWrappingImplementation.dart View 1 2 1 chunk +180 lines, -180 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLIsIndexElementWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLKeygenElementWrappingImplementation.dart View 1 2 1 chunk +32 lines, -32 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLLIElementWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLLabelElementWrappingImplementation.dart View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLLegendElementWrappingImplementation.dart View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLLinkElementWrappingImplementation.dart View 1 2 1 chunk +42 lines, -42 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLMapElementWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLMarqueeElementWrappingImplementation.dart View 1 2 1 chunk +44 lines, -44 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLMediaElementWrappingImplementation.dart View 1 2 1 chunk +84 lines, -84 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLMenuElementWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLMetaElementWrappingImplementation.dart View 1 2 1 chunk +16 lines, -16 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLMeterElementWrappingImplementation.dart View 1 2 1 chunk +28 lines, -28 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLModElementWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLOListElementWrappingImplementation.dart View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLObjectElementWrappingImplementation.dart View 1 2 1 chunk +74 lines, -74 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLOptGroupElementWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLOptionElementWrappingImplementation.dart View 1 2 1 chunk +28 lines, -28 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLOptionsCollectionWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLOutputElementWrappingImplementation.dart View 1 2 1 chunk +28 lines, -28 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLParagraphElementWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLParamElementWrappingImplementation.dart View 1 2 1 chunk +16 lines, -16 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLPreElementWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLProgressElementWrappingImplementation.dart View 1 2 1 chunk +14 lines, -14 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLQuoteElementWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLScriptElementWrappingImplementation.dart View 1 2 1 chunk +32 lines, -32 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLSelectElementWrappingImplementation.dart View 1 2 1 chunk +50 lines, -50 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLSourceElementWrappingImplementation.dart View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLStyleElementWrappingImplementation.dart View 1 2 1 chunk +14 lines, -14 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLTableCaptionElementWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLTableCellElementWrappingImplementation.dart View 1 2 1 chunk +58 lines, -58 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLTableColElementWrappingImplementation.dart View 1 2 1 chunk +24 lines, -24 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLTableElementWrappingImplementation.dart View 1 2 1 chunk +52 lines, -52 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLTableRowElementWrappingImplementation.dart View 1 2 1 chunk +26 lines, -26 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLTableSectionElementWrappingImplementation.dart View 1 2 1 chunk +18 lines, -18 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLTextAreaElementWrappingImplementation.dart View 1 2 1 chunk +78 lines, -78 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLTitleElementWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLTrackElementWrappingImplementation.dart View 1 2 1 chunk +22 lines, -22 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLUListElementWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_HTMLVideoElementWrappingImplementation.dart View 1 2 1 chunk +24 lines, -24 lines 0 comments Download
M client/dom/generated/src/wrapping/_HashChangeEventWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_HistoryWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBCursorWithValueWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBCursorWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBDatabaseErrorWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBDatabaseExceptionWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBDatabaseWrappingImplementation.dart View 1 2 1 chunk +16 lines, -16 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBIndexWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBKeyRangeWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBObjectStoreWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBRequestWrappingImplementation.dart View 1 2 1 chunk +20 lines, -20 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBTransactionWrappingImplementation.dart View 1 2 1 chunk +16 lines, -16 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBVersionChangeEventWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_IDBVersionChangeRequestWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_ImageDataWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_Int16ArrayWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_Int32ArrayWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_Int8ArrayWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_JavaScriptCallFrameWrappingImplementation.dart View 1 2 1 chunk +14 lines, -14 lines 0 comments Download
M client/dom/generated/src/wrapping/_KeyboardEventWrappingImplementation.dart View 1 2 1 chunk +14 lines, -14 lines 0 comments Download
M client/dom/generated/src/wrapping/_LocationWrappingImplementation.dart View 1 2 1 chunk +34 lines, -34 lines 0 comments Download
M client/dom/generated/src/wrapping/_MediaErrorWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_MediaListWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_MediaQueryListWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_MemoryInfoWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_MessageChannelWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_MessageEventWrappingImplementation.dart View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M client/dom/generated/src/wrapping/_MessagePortWrappingImplementation.dart View 1 2 3 chunks +14 lines, -14 lines 0 comments Download
M client/dom/generated/src/wrapping/_MetadataWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_MouseEventWrappingImplementation.dart View 1 2 1 chunk +34 lines, -34 lines 0 comments Download
M client/dom/generated/src/wrapping/_MutationEventWrappingImplementation.dart View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M client/dom/generated/src/wrapping/_MutationRecordWrappingImplementation.dart View 1 2 1 chunk +18 lines, -18 lines 0 comments Download
M client/dom/generated/src/wrapping/_NamedNodeMapWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_NavigatorUserMediaErrorWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_NavigatorWrappingImplementation.dart View 1 2 1 chunk +28 lines, -28 lines 0 comments Download
M client/dom/generated/src/wrapping/_NodeIteratorWrappingImplementation.dart View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M client/dom/generated/src/wrapping/_NodeListWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_NodeWrappingImplementation.dart View 1 2 3 chunks +50 lines, -50 lines 0 comments Download
M client/dom/generated/src/wrapping/_NotationWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_NotificationWrappingImplementation.dart View 1 2 2 chunks +34 lines, -34 lines 0 comments Download
M client/dom/generated/src/wrapping/_OperationNotAllowedExceptionWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_OverflowEventWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_PageTransitionEventWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_PerformanceNavigationWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_PerformanceTimingWrappingImplementation.dart View 1 2 1 chunk +42 lines, -42 lines 0 comments Download
M client/dom/generated/src/wrapping/_PerformanceWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_PopStateEventWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_PositionErrorWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_ProcessingInstructionWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_ProgressEventWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_RGBColorWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_RangeExceptionWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_RangeWrappingImplementation.dart View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M client/dom/generated/src/wrapping/_RectWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_SQLErrorWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_SQLExceptionWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_SQLResultSetRowListWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_SQLResultSetWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_ScreenWrappingImplementation.dart View 1 2 1 chunk +16 lines, -16 lines 0 comments Download
M client/dom/generated/src/wrapping/_ScriptProfileNodeWrappingImplementation.dart View 1 2 1 chunk +18 lines, -18 lines 0 comments Download
M client/dom/generated/src/wrapping/_ScriptProfileWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_SharedWorkerWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_SharedWorkercontextWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_SpeechInputEventWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_SpeechInputResultListWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_SpeechInputResultWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_StorageEventWrappingImplementation.dart View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M client/dom/generated/src/wrapping/_StorageWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_StyleMediaWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_StyleSheetListWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_StyleSheetWrappingImplementation.dart View 1 2 1 chunk +16 lines, -16 lines 0 comments Download
M client/dom/generated/src/wrapping/_TextEventWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_TextMetricsWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_TextTrackCueListWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_TextTrackCueWrappingImplementation.dart View 1 2 1 chunk +22 lines, -22 lines 0 comments Download
M client/dom/generated/src/wrapping/_TextTrackWrappingImplementation.dart View 1 2 1 chunk +16 lines, -16 lines 0 comments Download
M client/dom/generated/src/wrapping/_TextWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_TimeRangesWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_TouchEventWrappingImplementation.dart View 1 2 1 chunk +14 lines, -14 lines 0 comments Download
M client/dom/generated/src/wrapping/_TouchListWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_TouchWrappingImplementation.dart View 1 2 1 chunk +24 lines, -24 lines 0 comments Download
M client/dom/generated/src/wrapping/_TreeWalkerWrappingImplementation.dart View 1 2 1 chunk +12 lines, -12 lines 0 comments Download
M client/dom/generated/src/wrapping/_UIEventWrappingImplementation.dart View 1 2 1 chunk +18 lines, -18 lines 0 comments Download
M client/dom/generated/src/wrapping/_Uint16ArrayWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_Uint32ArrayWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_Uint8ArrayWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_ValidityStateWrappingImplementation.dart View 1 2 1 chunk +18 lines, -18 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebGLActiveInfoWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebGLContextAttributesWrappingImplementation.dart View 1 2 1 chunk +24 lines, -24 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebGLContextEventWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebGLRenderingContextWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebKitAnimationEventWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebKitAnimationListWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebKitAnimationWrappingImplementation.dart View 1 2 1 chunk +20 lines, -20 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebKitCSSFilterValueWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebKitCSSKeyframeRuleWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebKitCSSKeyframesRuleWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebKitCSSMatrixWrappingImplementation.dart View 1 2 1 chunk +88 lines, -88 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebKitCSSTransformValueWrappingImplementation.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebKitFlagsWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebKitPointWrappingImplementation.dart View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebKitTransitionEventWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_WebSocketWrappingImplementation.dart View 1 2 2 chunks +40 lines, -40 lines 0 comments Download
M client/dom/generated/src/wrapping/_WheelEventWrappingImplementation.dart View 1 2 1 chunk +32 lines, -32 lines 0 comments Download
M client/dom/generated/src/wrapping/_WorkerContextWrappingImplementation.dart View 1 2 1 chunk +20 lines, -20 lines 0 comments Download
M client/dom/generated/src/wrapping/_WorkerLocationWrappingImplementation.dart View 1 2 1 chunk +16 lines, -16 lines 0 comments Download
M client/dom/generated/src/wrapping/_WorkerNavigatorWrappingImplementation.dart View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M client/dom/generated/src/wrapping/_WorkerWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_XMLHttpRequestExceptionWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_XMLHttpRequestProgressEventWrappingImplementation.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M client/dom/generated/src/wrapping/_XMLHttpRequestUploadWrappingImplementation.dart View 1 2 1 chunk +30 lines, -30 lines 0 comments Download
M client/dom/generated/src/wrapping/_XMLHttpRequestWrappingImplementation.dart View 1 2 3 chunks +60 lines, -60 lines 0 comments Download
M client/dom/generated/src/wrapping/_XPathExceptionWrappingImplementation.dart View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M client/dom/generated/src/wrapping/_XPathResultWrappingImplementation.dart View 1 2 1 chunk +14 lines, -14 lines 0 comments Download
M client/dom/generated/wrapping_dom.js View 1 2 2351 chunks +2351 lines, -2351 lines 0 comments Download
M client/dom/scripts/dartgenerator.py View 1 2 8 chunks +109 lines, -61 lines 1 comment Download
M client/dom/scripts/template_wrapping_dom.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
9 years, 1 month ago (2011-11-18 05:29:17 UTC) #1
vsm
9 years, 1 month ago (2011-11-18 05:42:28 UTC) #2
LGTM

http://codereview.chromium.org/8548010/diff/12015/client/dom/scripts/dartgene...
File client/dom/scripts/dartgenerator.py (right):

http://codereview.chromium.org/8548010/diff/12015/client/dom/scripts/dartgene...
client/dom/scripts/dartgenerator.py:560: return result;
Can you get duplicates from diamond inheritance?  Or, if the secondary parents
overlaps the primary above?

Powered by Google App Engine
This is Rietveld 408576698