Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 8545003: Parser fix for lambdas (Closed)

Created:
9 years, 1 month ago by Jennifer Messerly
Modified:
9 years, 1 month ago
Reviewers:
jimhug
CC:
reviews_dartlang.org, sra1
Visibility:
Public.

Description

Parser fix for lambdas. All the heavy lifting courtesy of Stephen :) (http://codereview.chromium.org/8400017/) Only difference in this version is using a List instead of a Map (due to Maps having not so great performance at the moment when the keys are numbers. And we could get even better perf by tweaking this to cache the lookahead on the Token, if we really wanted to) Committed: https://code.google.com/p/dart/source/detail?r=1683

Patch Set 1 #

Patch Set 2 : merged #

Patch Set 3 : fix parser #

Patch Set 4 : update status #

Patch Set 5 : merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -276 lines) Patch
M client/tests/client/client.status View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M frog/frogsh View 1 2 3 4 26 chunks +116 lines, -130 lines 0 comments Download
M frog/lib/corelib_impl.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M frog/member.dart View 1 1 chunk +7 lines, -5 lines 0 comments Download
M frog/parser.dart View 1 2 15 chunks +129 lines, -132 lines 0 comments Download
M frog/tokenizer.dart View 1 2 3 4 2 chunks +8 lines, -1 line 0 comments Download
M tests/co19/co19-frog.status View 1 2 chunks +0 lines, -5 lines 0 comments Download
M tests/language/language.status View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Jennifer Messerly
9 years, 1 month ago (2011-11-19 01:41:25 UTC) #1
tbr

Powered by Google App Engine
This is Rietveld 408576698