Issue 8540002: Use the configuration for determining the binary to use for testing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8540002: Use the configuration for determining the binary to use for testing. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)

Modified:
9 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Use the configuration for determining the binary to use for testing. So far supporting components vm and dartc. Also, use the actual configuration for status file parsing. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1450

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -35 lines)			Patch
M	tests/corelib/test_config.dart	View	1 chunk	+3 lines, -8 lines	0 comments	Download
M	tests/standalone/src/StatusExpressionTest.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/standalone/src/TestRunnerTest.dart	View	2 chunks	+17 lines, -1 line	0 comments	Download
M	tests/standalone/test_config.dart	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	tools/test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/testing/dart/status_expression.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1 chunk	+27 lines, -12 lines	0 comments	Download

Total messages: 2 (0 generated)

Bill Hesse

9 years, 1 month ago (2011-11-11 09:26:05 UTC) #2

LGTM.  I see you kept TestRunnerTest working on Win32 with a workaround.