Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 8539044: Enable co19 test suite on dart test scripts. (Closed)

Created:
9 years, 1 month ago by Mads Ager (google)
Modified:
9 years, 1 month ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Enable co19 test suite on dart test scripts. Updated the TestExpectations class to be able to deal with the odd matching rules that are used for co19. Currently we are using a lot of memory when running all of these tests. I have optimized the test expectation part quite a bit. The thing that seems bad now if the processing of all the lines of every simple test to find DartOptions. We need to work on that. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=1563

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -69 lines) Patch
M tests/co19/co19-runtime.status View 1 1 chunk +0 lines, -12 lines 0 comments Download
A + tests/co19/test_config.dart View 1 8 chunks +46 lines, -24 lines 0 comments Download
M tests/corelib/test_config.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M tests/standalone/test_config.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M tools/test.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/testing/dart/status_file_parser.dart View 3 chunks +122 lines, -13 lines 0 comments Download
M tools/testing/dart/test_options.dart View 3 chunks +7 lines, -3 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 2 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
9 years, 1 month ago (2011-11-16 10:51:34 UTC) #1
Bill Hesse
We already have support for negative tests, in the test runner and TestCase and TestOutput ...
9 years, 1 month ago (2011-11-16 11:44:27 UTC) #2
Mads Ager (google)
9 years, 1 month ago (2011-11-16 12:26:38 UTC) #3
http://codereview.chromium.org/8539044/diff/1/tests/co19/test_config.dart
File tests/co19/test_config.dart (right):

http://codereview.chromium.org/8539044/diff/1/tests/co19/test_config.dart#new...
tests/co19/test_config.dart:107: 
On 2011/11/16 11:44:27, Bill Hesse wrote:
> We have handling for this in the test runner already.  You should set a
negative
> flag in the TestCase, so that TestCase.isNegative (a getter) returns true. 
This
> way, the counts of "Fail" are not artificially increased.

Good point. Done.

Powered by Google App Engine
This is Rietveld 408576698