Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 8539034: Add methods for creating Bigint objects from unsigned 64-bit integers. (Closed)

Created:
9 years, 1 month ago by cshapiro
Modified:
9 years, 1 month ago
Reviewers:
Anton Muhin, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add methods for creating Bigint objects from unsigned 64-bit integers. Committed: https://code.google.com/p/dart/source/detail?r=1495

Patch Set 1 #

Total comments: 2

Patch Set 2 : Common subroutine for integer conversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -9 lines) Patch
M runtime/vm/bigint_operations.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/bigint_operations.cc View 1 4 chunks +33 lines, -9 lines 0 comments Download
M runtime/vm/bigint_operations_test.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cshapiro
9 years, 1 month ago (2011-11-12 00:49:25 UTC) #1
siva
lgtm http://codereview.chromium.org/8539034/diff/1/runtime/vm/bigint_operations.cc File runtime/vm/bigint_operations.cc (right): http://codereview.chromium.org/8539034/diff/1/runtime/vm/bigint_operations.cc#newcode356 runtime/vm/bigint_operations.cc:356: } This code here seems identical to ToInt64 ...
9 years, 1 month ago (2011-11-12 01:20:07 UTC) #2
cshapiro
PTAL http://codereview.chromium.org/8539034/diff/1/runtime/vm/bigint_operations.cc File runtime/vm/bigint_operations.cc (right): http://codereview.chromium.org/8539034/diff/1/runtime/vm/bigint_operations.cc#newcode356 runtime/vm/bigint_operations.cc:356: } Good idea. I am not sure how ...
9 years, 1 month ago (2011-11-12 01:50:09 UTC) #3
siva
LGTM
9 years, 1 month ago (2011-11-12 01:54:00 UTC) #4
Anton Muhin
May I ask you to expose this functionality via embedder's API as well?
9 years, 1 month ago (2011-11-15 14:43:35 UTC) #5
cshapiro
9 years, 1 month ago (2011-11-15 21:13:31 UTC) #6
Certainly.  I will put something together shortly that surfaces this through the
C API.

Powered by Google App Engine
This is Rietveld 408576698