Fix type mismatch errors. Environments do not only contain strings.

Fix type mismatch errors. Environments do not only contain strings.


R=whesse@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=1451

[Bill Hesse, 2011-11-11 09:40:47]

LGTM.  But this makes $checked == true return false no matter what the value of
checked.  People should not be writing this, but it won't give a syntax error. 
We don't have a way to write $checked == false now.

[Bill Hesse, 2011-11-11 09:43:19]

Proposed fix.

http://codereview.chromium.org/8539009/diff/1/tools/testing/dart/status_expre...
File tools/testing/dart/status_expression.dart (right):

http://codereview.chromium.org/8539009/diff/1/tools/testing/dart/status_expre...
tools/testing/dart/status_expression.dart:95: termValue(environment) =>
environment[name];
How about String termValue(environment) => environment[name].toString().  We
never want a boolean returned from this function, because it will be compared to
a string.

[Mads Ager (google), 2011-11-11 09:46:30]

http://codereview.chromium.org/8539009/diff/1/tools/testing/dart/status_expre...
File tools/testing/dart/status_expression.dart (right):

http://codereview.chromium.org/8539009/diff/1/tools/testing/dart/status_expre...
tools/testing/dart/status_expression.dart:95: termValue(environment) =>
environment[name];
On 2011/11/11 09:43:19, Bill Hesse wrote:
> How about String termValue(environment) => environment[name].toString().  We
> never want a boolean returned from this function, because it will be compared
to
> a string.

Sounds good to me. I'll do that as part of my next changelist. Thanks.