Issue 8538019: incremental progress on Value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8538019: incremental progress on Value (Closed)

Created:
9 years, 1 month ago by jimhug

Modified:
9 years, 1 month ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

incremental progress on Value I particularly like the fun type error this caught in corelib_impl. Committed: https://code.google.com/p/dart/source/detail?r=1472

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 4

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+335 lines, -356 lines)			Patch
M	frog/frogsh	View		182 chunks	+262 lines, -288 lines	0 comments	Download
M	frog/gen.dart	View		19 chunks	+35 lines, -42 lines	3 comments	Download
M	frog/lib/corelib_impl.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	frog/member.dart	View		5 chunks	+15 lines, -11 lines	0 comments	Download
M	frog/value.dart	View		8 chunks	+18 lines, -14 lines	0 comments	Download
M	tests/co19/co19-frog.status	View	1	2 chunks	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

9 years, 1 month ago (2011-11-12 00:39:58 UTC) #2

lgtm

http://codereview.chromium.org/8538019/diff/2001/frog/gen.dart
File frog/gen.dart (right):

http://codereview.chromium.org/8538019/diff/2001/frog/gen.dart#newcode1277
frog/gen.dart:1277: // TODO(jimhug): This is an egregious hack to get some
toStrings called.
Yeah, we probably just want to invoke all toStrings for live types.

http://codereview.chromium.org/8538019/diff/2001/frog/gen.dart#newcode1496
frog/gen.dart:1496: // TODO(jimhug): Replace with SuperValue.
+1

http://codereview.chromium.org/8538019/diff/2001/frog/gen.dart#newcode1616
frog/gen.dart:1616: return new Value(world.boolType, '${x.code} $op ${y.code}',
node.span);
it's funny, I caught this one too. But it's now it's world.nonNullBool :)

http://codereview.chromium.org/8538019/diff/2001/tests/co19/co19-frog.status
File tests/co19/co19-frog.status (right):

http://codereview.chromium.org/8538019/diff/2001/tests/co19/co19-frog.status#...
tests/co19/co19-frog.status:424: LibTest/core/Math/acos/Math/acos/A01/t01: Skip
# TODO(jimhug): bad test
I think Peter wanted these as "Pass, Fail" ?

Expand Messages | Collapse Messages